]> git.kaiwu.me - njs.git/commitdiff
Fixed use-of-uninitialized-value introduced in beb180165976.
authorDmitry Volyntsev <xeioex@nginx.com>
Tue, 24 May 2022 05:26:50 +0000 (22:26 -0700)
committerDmitry Volyntsev <xeioex@nginx.com>
Tue, 24 May 2022 05:26:50 +0000 (22:26 -0700)
Found by Memory Sanitizer.

src/njs_object.h

index 219f2f89e57c8a616f43c0d151f31bdc16133f58..db075edb2aa4f97fe947843d0082a8cce99888c0 100644 (file)
@@ -88,9 +88,10 @@ njs_int_t njs_object_prop_init(njs_vm_t *vm, const njs_object_init_t* init,
 njs_inline njs_bool_t
 njs_is_data_descriptor(njs_object_prop_t *prop)
 {
-    return njs_is_valid(&prop->value) ||
-           prop->writable != NJS_ATTRIBUTE_UNSET ||
-           prop->type == NJS_PROPERTY_HANDLER;
+    return prop->writable != NJS_ATTRIBUTE_UNSET
+           || njs_is_valid(&prop->value)
+           || prop->type == NJS_PROPERTY_HANDLER;
+
 }