]> git.kaiwu.me - nginx.git/commitdiff
Upstream: only call peer.free() if peer.get() selected a peer.
authorRuslan Ermilov <ru@nginx.com>
Mon, 25 Mar 2013 13:14:49 +0000 (13:14 +0000)
committerRuslan Ermilov <ru@nginx.com>
Mon, 25 Mar 2013 13:14:49 +0000 (13:14 +0000)
src/http/ngx_http_upstream.c

index 5cd42fe6c0579e8eea768666f0027a342b50e65d..61996cb60f6edb3a93b5e229654dc391d0353d04 100644 (file)
@@ -3147,14 +3147,16 @@ ngx_http_upstream_next(ngx_http_request_t *r, ngx_http_upstream_t *u,
     ngx_http_busy_unlock(u->conf->busy_lock, &u->busy_lock);
 #endif
 
-    if (ft_type == NGX_HTTP_UPSTREAM_FT_HTTP_404) {
-        state = NGX_PEER_NEXT;
-    } else {
-        state = NGX_PEER_FAILED;
-    }
+    if (u->peer.sockaddr) {
+
+        if (ft_type == NGX_HTTP_UPSTREAM_FT_HTTP_404) {
+            state = NGX_PEER_NEXT;
+        } else {
+            state = NGX_PEER_FAILED;
+        }
 
-    if (ft_type != NGX_HTTP_UPSTREAM_FT_NOLIVE) {
         u->peer.free(&u->peer, u->peer.data, state);
+        u->peer.sockaddr = NULL;
     }
 
     if (ft_type == NGX_HTTP_UPSTREAM_FT_TIMEOUT) {
@@ -3314,8 +3316,9 @@ ngx_http_upstream_finalize_request(ngx_http_request_t *r,
 
     u->finalize_request(r, rc);
 
-    if (u->peer.free) {
+    if (u->peer.free && u->peer.sockaddr) {
         u->peer.free(&u->peer, u->peer.data, 0);
+        u->peer.sockaddr = NULL;
     }
 
     if (u->peer.connection) {