]> git.kaiwu.me - haproxy.git/commitdiff
MINOR: mux-spop: Rely on spop_strm_notify_send() when resuming streams for sending
authorChristopher Faulet <cfaulet@haproxy.com>
Thu, 5 Mar 2026 16:08:13 +0000 (17:08 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 10 Mar 2026 14:10:34 +0000 (15:10 +0100)
In spop_resume_each_sending_spop_strm(), there was exactly the same code
than spop_strm_notify_send(). So let's use spop_strm_notify_send() instead
of duplicating code.

src/mux_spop.c

index 57686838e5caa36901383d0f7d308a2aaff01980..082108f831fec172274bd94e8123cb179b23e9ab 100644 (file)
@@ -2023,13 +2023,7 @@ static void spop_resume_each_sending_spop_strm(struct spop_conn *spop_conn, stru
                        continue;
                }
 
-               if (spop_strm->subs && spop_strm->subs->events & SUB_RETRY_SEND) {
-                       spop_strm->flags |= SPOP_SF_NOTIFIED;
-                       tasklet_wakeup(spop_strm->subs->tasklet);
-                       spop_strm->subs->events &= ~SUB_RETRY_SEND;
-                       if (!spop_strm->subs->events)
-                               spop_strm->subs = NULL;
-               }
+               spop_strm_notify_send(spop_strm);
        }
 
        TRACE_LEAVE(SPOP_EV_SPOP_CONN_SEND|SPOP_EV_STRM_WAKE, spop_conn->conn);