]> git.kaiwu.me - nginx.git/commitdiff
Reorder checks in ngx_shared_memory_add() for more consistent error messages.
authorAndrey Belov <defan@nginx.com>
Wed, 1 Aug 2012 14:37:08 +0000 (14:37 +0000)
committerAndrey Belov <defan@nginx.com>
Wed, 1 Aug 2012 14:37:08 +0000 (14:37 +0000)
src/core/ngx_cycle.c

index 2da0bf91a65d8b2afd39fefde348ec7e2f3be76b..e5468ae9b1abc7cf4d0313f13b70e641599a456d 100644 (file)
@@ -1285,14 +1285,6 @@ ngx_shared_memory_add(ngx_conf_t *cf, ngx_str_t *name, size_t size, void *tag)
             continue;
         }
 
-        if (size && size != shm_zone[i].shm.size) {
-            ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
-                            "the size %uz of shared memory zone \"%V\" "
-                            "conflicts with already declared size %uz",
-                            size, &shm_zone[i].shm.name, shm_zone[i].shm.size);
-            return NULL;
-        }
-
         if (tag != shm_zone[i].tag) {
             ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
                             "the shared memory zone \"%V\" is "
@@ -1301,6 +1293,14 @@ ngx_shared_memory_add(ngx_conf_t *cf, ngx_str_t *name, size_t size, void *tag)
             return NULL;
         }
 
+        if (size && size != shm_zone[i].shm.size) {
+            ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
+                            "the size %uz of shared memory zone \"%V\" "
+                            "conflicts with already declared size %uz",
+                            size, &shm_zone[i].shm.name, shm_zone[i].shm.size);
+            return NULL;
+        }
+
         return &shm_zone[i];
     }