]> git.kaiwu.me - nginx.git/commit
Gzip: fixed setting of NGX_HTTP_GZIP_BUFFERED.
authorValentin Bartenev <vbart@nginx.com>
Mon, 11 Mar 2013 11:19:58 +0000 (11:19 +0000)
committerValentin Bartenev <vbart@nginx.com>
Mon, 11 Mar 2013 11:19:58 +0000 (11:19 +0000)
commitb8cba361f7547310d574d82aecce5fe52ff43279
tree87454d11e6eabf46191cf52554c3e62c8e99b859
parent8fbef4841fe21ef2760c2313152180c56c6edd05
Gzip: fixed setting of NGX_HTTP_GZIP_BUFFERED.

In r2411 setting of NGX_HTTP_GZIP_BUFFERED in c->buffered was moved from
ngx_http_gzip_filter_deflate_start() to ngx_http_gzip_filter_buffer() since
it was always called first.  But in r2543 the "postpone_gzipping" directive
was introduced, and if postponed gzipping is disabled (the default setting),
ngx_http_gzip_filter_buffer() is not called at all.

We must always set NGX_HTTP_GZIP_BUFFERED after the start of compression
since there is always a trailer that is buffered.

There are no known cases when it leads to any problem with current code.
But we already had troubles in upcoming SPDY implementation.
src/http/modules/ngx_http_gzip_filter_module.c