]> git.kaiwu.me - nginx.git/commit
Resolver: fixed crashes in timeout handler.
authorRuslan Ermilov <ru@nginx.com>
Tue, 26 Jan 2016 13:46:31 +0000 (16:46 +0300)
committerRuslan Ermilov <ru@nginx.com>
Tue, 26 Jan 2016 13:46:31 +0000 (16:46 +0300)
commit84ae282f938068fa5c09f7c157ea0086b2ab760b
tree8f778791f9d4d41542841c58a1b3613c3d012177
parent717f65a5072d67e851c5e2f755eb7179a343c112
Resolver: fixed crashes in timeout handler.

If one or more requests were waiting for a response, then after
getting a CNAME response, the timeout event on the first request
remained active, pointing to the wrong node with an empty
rn->waiting list, and that could cause either null pointer
dereference or use-after-free memory access if this timeout
expired.

If several requests were waiting for a response, and the first
request terminated (e.g., due to client closing a connection),
other requests were left without a timeout and could potentially
wait indefinitely.

This is fixed by introducing per-request independent timeouts.
This change also reverts 954867a2f0a6 and 5004210e8c78.
src/core/ngx_resolver.c
src/core/ngx_resolver.h