]> git.kaiwu.me - nginx.git/commit
projects / nginx.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ca53600) | patch
HTTP/2: don't send SETTINGS ACK before already queued DATA frames.
authorPiotr Sikora <piotrsikora@google.com>
Fri, 2 Jun 2017 12:05:32 +0000 (15:05 +0300)
committerPiotr Sikora <piotrsikora@google.com>
Fri, 2 Jun 2017 12:05:32 +0000 (15:05 +0300)
commit51a4a414ca051c779ac90a566bd50c0a1ecd6a40
treee59c6d2d8bed9e8486e5f58bc64970477b0942eetree | snapshot
parentca53600ac01de47e1f11d2176310cdf6621a67facommit | diff
HTTP/2: don't send SETTINGS ACK before already queued DATA frames.

Previously, SETTINGS ACK was sent immediately upon receipt of SETTINGS
frame, before already queued DATA frames created using old SETTINGS.

This incorrect behavior was source of interoperability issues, because
peers rely on the fact that new SETTINGS are in effect after receiving
SETTINGS ACK.

Reported by Feng Li.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
src/http/v2/ngx_http_v2.c diff | blob | history
src/http/v2/ngx_http_v2.h diff | blob | history
nginx upstream