]> git.kaiwu.me - nginx.git/commit
Lingering close changed to handle NGX_AGAIN.
authorMaxim Dounin <mdounin@mdounin.ru>
Mon, 10 Sep 2018 15:57:13 +0000 (18:57 +0300)
committerMaxim Dounin <mdounin@mdounin.ru>
Mon, 10 Sep 2018 15:57:13 +0000 (18:57 +0300)
commit278be041ddbd91c28b496ca01213c47cbc96d958
treec52f01192ece8bb4cfade42b01e0f2272935a4f0
parent07dbfd00fff456d05007cc1f35bd5a5b1349ef08
Lingering close changed to handle NGX_AGAIN.

The "do { c->recv() } while (c->read->ready)" form used in the
ngx_http_lingering_close_handler() is not really correct, as for
example with SSL c->read->ready may be still set when returning NGX_AGAIN
due to SSL_ERROR_WANT_WRITE.  Therefore the above might be an infinite loop.

This doesn't really matter in lingering close, as we shutdown write side
of the socket anyway and also disable renegotiation (and even without shutdown
and with renegotiation it requires using very large certificate chain and
tuning socket buffers to trigger SSL_ERROR_WANT_WRITE).  But for the sake of
correctness added an NGX_AGAIN check.
src/http/ngx_http_request.c