]> git.kaiwu.me - nginx.git/commit
HTTP/2: fixed closed_nodes overflow (ticket #1708).
authorMaxim Dounin <mdounin@mdounin.ru>
Thu, 3 Feb 2022 19:46:01 +0000 (22:46 +0300)
committerMaxim Dounin <mdounin@mdounin.ru>
Thu, 3 Feb 2022 19:46:01 +0000 (22:46 +0300)
commit0a90893da03517a17562feb69b170af0365b2068
treec4c08967742632d6b9056bcd94ff6461b993a35c
parenta52433a04c58821fd95591e474d35995292f1090
HTTP/2: fixed closed_nodes overflow (ticket #1708).

With large http2_max_concurrent_streams or http2_max_concurrent_pushes, more
than 255 ngx_http_v2_node_t structures might be allocated, eventually leading
to h2c->closed_nodes overflow when closing corresponding streams.  This will
in turn result in additional allocations in ngx_http_v2_get_node_by_id().

While mostly harmless, it can result in excessive memory usage by a HTTP/2
connection, notably in configurations with many keepalive_requests allowed.
Fix is to use ngx_uint_t for h2c->closed_nodes instead of unsigned:8.
src/http/v2/ngx_http_v2.h