aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/xml.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-03-08 16:10:00 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2017-03-08 16:10:00 -0500
commitf379121093deb5465b01d93ebe9410d96c6cd093 (patch)
tree9bee16c1f32bad35a10b42d22f210d2c7b22a4ff /src/backend/utils/adt/xml.c
parent86dbbf20d8496ede77566873d1e22cd11c1e544c (diff)
downloadpostgresql-f379121093deb5465b01d93ebe9410d96c6cd093.tar.gz
postgresql-f379121093deb5465b01d93ebe9410d96c6cd093.zip
Suppress compiler warning in non-USE_LIBXML builds.
Compilers that don't realize that ereport(ERROR) doesn't return complained that XmlTableGetValue() failed to return a value. Also, make XmlTableFetchRow's non-USE_LIBXML case look more like the other ones. As coded, it could lead to "unreachable code" warnings with USE_LIBXML enabled. Oversights in commit fcec6caaf. Per buildfarm.
Diffstat (limited to 'src/backend/utils/adt/xml.c')
-rw-r--r--src/backend/utils/adt/xml.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index 7fd3ec3fae7..04aeb7178e9 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -4389,9 +4389,8 @@ XmlTableFetchRow(TableFuncScanState *state)
return false;
#else
NO_XML_SUPPORT();
-#endif /* not USE_LIBXML */
-
return false;
+#endif /* not USE_LIBXML */
}
/*
@@ -4561,6 +4560,7 @@ XmlTableGetValue(TableFuncScanState *state, int colnum,
return result;
#else
NO_XML_SUPPORT();
+ return 0;
#endif /* not USE_LIBXML */
}