diff options
| author | Andres Freund <andres@anarazel.de> | 2018-07-22 14:58:01 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2018-07-22 14:58:23 -0700 |
| commit | 86eaf208ea048936df6be77276a246d3f92e9620 (patch) | |
| tree | d0b7d529bba5f072457c003c951d05ca2aa90caa /src/backend/utils/adt/arrayutils.c | |
| parent | 3522d0eaba5a976f09a48810dd25dff6ab3565df (diff) | |
| download | postgresql-86eaf208ea048936df6be77276a246d3f92e9620.tar.gz postgresql-86eaf208ea048936df6be77276a246d3f92e9620.zip | |
Hand code string to integer conversion for performance.
As benchmarks show, using libc's string-to-integer conversion is
pretty slow. At least part of the reason for that is that strtol[l]
have to be more generic than what largely is required inside pg.
This patch considerably speeds up int2/int4 input (int8 already was
already using hand-rolled code).
Most of the existing pg_atoi callers have been converted. But as one
requires pg_atoi's custom delimiter functionality, and as it seems
likely that there's external pg_atoi users, it seems sensible to just
keep pg_atoi around.
Author: Andres Freund
Reviewed-By: Robert Haas
Discussion: https://postgr.es/m/20171208214437.qgn6zdltyq5hmjpk@alap3.anarazel.de
Diffstat (limited to 'src/backend/utils/adt/arrayutils.c')
| -rw-r--r-- | src/backend/utils/adt/arrayutils.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/utils/adt/arrayutils.c b/src/backend/utils/adt/arrayutils.c index c0d719e98cc..5b98efe76bc 100644 --- a/src/backend/utils/adt/arrayutils.c +++ b/src/backend/utils/adt/arrayutils.c @@ -226,8 +226,7 @@ ArrayGetIntegerTypmods(ArrayType *arr, int *n) result = (int32 *) palloc(*n * sizeof(int32)); for (i = 0; i < *n; i++) - result[i] = pg_atoi(DatumGetCString(elem_values[i]), - sizeof(int32), '\0'); + result[i] = pg_strtoint32(DatumGetCString(elem_values[i])); pfree(elem_values); |