aboutsummaryrefslogtreecommitdiff
path: root/src/backend/utils/adt/arrayfuncs.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-09-24 12:05:06 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-09-24 12:05:06 -0400
commit8485a25a8c9a419ff3e0d30e43e4abd5e680cc65 (patch)
tree29b32a1524550759e95f4906c33c267f6e60881e /src/backend/utils/adt/arrayfuncs.c
parent6dda0998afc7d449145b9ba216844bdba7a817d6 (diff)
downloadpostgresql-8485a25a8c9a419ff3e0d30e43e4abd5e680cc65.tar.gz
postgresql-8485a25a8c9a419ff3e0d30e43e4abd5e680cc65.zip
Fix assorted infelicities in new SetWALSegSize() function.
* Failure to check for malloc failure (ok, pretty unlikely here, but that's not an excuse). * Leakage of open fd on read error, and of malloc'd buffer always. * Incorrect assumption that a short read would set errno to zero. * Failure to adhere to message style conventions (in particular, not reporting errno where relevant; using "couldn't open" rather than "could not open" is not really in line with project style either). * Missing newlines on some messages. Coverity spotted the leak problems; I noticed the rest while fixing the leaks.
Diffstat (limited to 'src/backend/utils/adt/arrayfuncs.c')
0 files changed, 0 insertions, 0 deletions