diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2001-12-04 19:40:17 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2001-12-04 19:40:17 +0000 |
| commit | f4bd04bb67c5da67b4fc35aa4da4ac47cff4cd66 (patch) | |
| tree | 60021bf58981f978795048a26038ab07702a9940 /src/backend/tcop/postgres.c | |
| parent | dae887abfe54b10820e03f0de82542306d825b00 (diff) | |
| download | postgresql-f4bd04bb67c5da67b4fc35aa4da4ac47cff4cd66.tar.gz postgresql-f4bd04bb67c5da67b4fc35aa4da4ac47cff4cd66.zip | |
Replace pq_getbytes(&ch, 1) calls with pq_getbyte(), which is easier
to use and significantly faster. This tweak saves 25% (!) of the runtime
of COPY IN in a test with 8000-character lines. I wouldn't normally
commit a performance improvement this late in the cycle, but 25% got
my attention...
Diffstat (limited to 'src/backend/tcop/postgres.c')
| -rw-r--r-- | src/backend/tcop/postgres.c | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index c7b227cd715..85d0346b65e 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.242 2001/11/10 23:51:14 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.243 2001/12/04 19:40:17 tgl Exp $ * * NOTES * this is the "main" module of the postgres backend and @@ -242,25 +242,25 @@ InteractiveBackend(StringInfo inBuf) static int SocketBackend(StringInfo inBuf) { - char qtype; - char result = '\0'; + int qtype; /* * get input from the frontend */ - qtype = '?'; - if (pq_getbytes(&qtype, 1) == EOF) - return EOF; + qtype = pq_getbyte(); switch (qtype) { + case EOF: + /* frontend disconnected */ + break; + /* * 'Q': user entered a query */ case 'Q': if (pq_getstr(inBuf)) return EOF; - result = 'Q'; break; /* @@ -269,14 +269,12 @@ SocketBackend(StringInfo inBuf) case 'F': if (pq_getstr(inBuf)) return EOF; /* ignore "string" at start of F message */ - result = 'F'; break; /* * 'X': frontend is exiting */ case 'X': - result = 'X'; break; /* @@ -289,7 +287,8 @@ SocketBackend(StringInfo inBuf) elog(FATAL, "Socket command type %c unknown", qtype); break; } - return result; + + return qtype; } /* ---------------- @@ -1627,7 +1626,7 @@ PostgresMain(int argc, char *argv[], const char *username) if (!IsUnderPostmaster) { puts("\nPOSTGRES backend interactive interface "); - puts("$Revision: 1.242 $ $Date: 2001/11/10 23:51:14 $\n"); + puts("$Revision: 1.243 $ $Date: 2001/12/04 19:40:17 $\n"); } /* |