diff options
| author | Robert Haas <rhaas@postgresql.org> | 2019-09-06 08:22:32 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2019-09-06 08:53:13 -0400 |
| commit | 61c65cce40e683333c43abb12a9c81ed659c8de0 (patch) | |
| tree | 0caaad7b3aa567a2c60f2da3f410b87d6a722283 /src/backend/access/gist/gistutil.c | |
| parent | af28744288b1de46615c947be69935c2172374c7 (diff) | |
| download | postgresql-61c65cce40e683333c43abb12a9c81ed659c8de0.tar.gz postgresql-61c65cce40e683333c43abb12a9c81ed659c8de0.zip | |
When performing a base backup, check for read errors.
The old code didn't differentiate between a read error and a
concurrent truncation. fread reports both of these by returning 0;
you have to use feof() or ferror() to distinguish between them,
which this code did not do.
It might be a better idea to use read() rather than fread() here,
so that we can display a less-generic error message, but I'm not
sure that would qualify as a back-patchable bug fix, so just do
this much for now.
Jeevan Chalke, reviewed by Jeevan Ladhe and by me.
Discussion: http://postgr.es/m/CA+TgmobG4ywMzL5oQq2a8YKp8x2p3p1LOMMcGqpS7aekT9+ETA@mail.gmail.com
Diffstat (limited to 'src/backend/access/gist/gistutil.c')
0 files changed, 0 insertions, 0 deletions