diff options
author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2017-08-02 18:26:26 -0400 |
---|---|---|
committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2017-08-02 18:26:58 -0400 |
commit | f3142c027212967e0417ad3377563bbc8f314fce (patch) | |
tree | 860dbd96b2ad25aa372d8ec20fe8f0a6a19d177a /src/backend/access/gist/gistutil.c | |
parent | 331bf9d8a31384f092599ad86529e3f64a27a8af (diff) | |
download | postgresql-f3142c027212967e0417ad3377563bbc8f314fce.tar.gz postgresql-f3142c027212967e0417ad3377563bbc8f314fce.zip |
Fix pg_dump's errno checking for zlib I/O
Some error reports were reporting strerror(errno), which for some error
conditions coming from zlib are wrong, resulting in confusing reports
such as
pg_restore: [compress_io] could not read from input file: Success
which makes no sense. To correctly extract the error message we need to
use gzerror(), so let's do that.
This isn't as comprehensive or as neat as I would like, but at least it
should improve things in many common cases. The zlib abstraction in
compress_io does not seem to be applied consistently enough; we could
perhaps improve that, but it seems master-only material, not a bug fix
for back-patching.
This problem goes back all the way, but I decided to apply back to 9.4
only, because older branches don't contain commit 14ea89366 which this
change depends on.
Authors: Vladimir Kunschikov, Álvaro Herrera
Discussion: https://postgr.es/m/1498120508308.9826@infotecs.ru
Diffstat (limited to 'src/backend/access/gist/gistutil.c')
0 files changed, 0 insertions, 0 deletions