diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-10-07 18:41:39 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-10-07 18:42:02 -0400 |
| commit | dc14aa038e20d0287a569c36498da9469fe9d4e3 (patch) | |
| tree | cc6fea02e0bd7fae13f40b63a399d82be46925a4 /src/backend/access/gist/gistbuildbuffers.c | |
| parent | 5ed20a689e3d5d47a70b971f388e9da2a996dea9 (diff) | |
| download | postgresql-dc14aa038e20d0287a569c36498da9469fe9d4e3.tar.gz postgresql-dc14aa038e20d0287a569c36498da9469fe9d4e3.zip | |
Fix optimization hazard in gram.y's makeOrderedSetArgs(), redux.
It appears that commit cf63c641c, which intended to prevent
misoptimization of the result-building step in makeOrderedSetArgs,
didn't go far enough: buildfarm member hornet's version of xlc
is now optimizing back to the old, broken behavior in which
list_length(directargs) is fetched only after list_concat() has
changed that value. I'm not entirely convinced whether that's
an undeniable compiler bug or whether it can be justified by a
sufficiently aggressive interpretation of C sequence points.
So let's just change the code to make it harder to misinterpret.
Back-patch to all supported versions, just in case.
Discussion: https://postgr.es/m/1830491.1601944935@sss.pgh.pa.us
Diffstat (limited to 'src/backend/access/gist/gistbuildbuffers.c')
0 files changed, 0 insertions, 0 deletions