diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-01 17:28:01 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-01 17:28:01 -0400 |
commit | a2098b60216c7a66054ee7b31e9f728bca43d004 (patch) | |
tree | d32a5697d20b1b5df94529ca7676d896d8be66d4 /src/backend/access/gist/gist.c | |
parent | 573478564705a801f7313bb793f05932cb875528 (diff) | |
download | postgresql-a2098b60216c7a66054ee7b31e9f728bca43d004.tar.gz postgresql-a2098b60216c7a66054ee7b31e9f728bca43d004.zip |
Get rid of trailing semicolons in C macro definitions.
Writing a trailing semicolon in a macro is almost never the right thing,
because you almost always want to write a semicolon after each macro
call instead. (Even if there was some reason to prefer not to, pgindent
would probably make a hash of code formatted that way; so within PG the
rule should basically be "don't do it".) Thus, if we have a semi inside
the macro, the compiler sees "something;;". Much of the time the extra
empty statement is harmless, but it could lead to mysterious syntax
errors at call sites. In perhaps an overabundance of neatnik-ism, let's
run around and get rid of the excess semicolons whereever possible.
The only thing worse than a mysterious syntax error is a mysterious
syntax error that only happens in the back branches; therefore,
backpatch these changes where relevant, which is most of them because
most of these mistakes are old. (The lack of reported problems shows
that this is largely a hypothetical issue, but still, it could bite
us in some future patch.)
John Naylor and Tom Lane
Discussion: https://postgr.es/m/CACPNZCs0qWTqJ2QUSGJ07B7uvAvzMb-KbG2q+oo+J3tsWN5cqw@mail.gmail.com
Diffstat (limited to 'src/backend/access/gist/gist.c')
0 files changed, 0 insertions, 0 deletions