diff options
author | Robert Haas <rhaas@postgresql.org> | 2015-11-03 09:12:52 -0500 |
---|---|---|
committer | Robert Haas <rhaas@postgresql.org> | 2015-11-03 09:12:52 -0500 |
commit | 4efe26cbd3ef0d85656bf00ac9e5bd41cc8a2a36 (patch) | |
tree | 85aa24973256684c420378fe4f3264a3c9bfc01d /contrib/postgres_fdw/postgres_fdw.h | |
parent | 0279f62fdca7ff19ef34a836f5201935dc7f627c (diff) | |
download | postgresql-4efe26cbd3ef0d85656bf00ac9e5bd41cc8a2a36.tar.gz postgresql-4efe26cbd3ef0d85656bf00ac9e5bd41cc8a2a36.zip |
shm_mq: Third attempt at fixing nowait behavior in shm_mq_receive.
Commit a1480ec1d3bacb9acb08ec09f22bc25bc033115b purported to fix the
problems with commit b2ccb5f4e6c81305386edb34daf7d1d1e1ee112a, but it
didn't completely fix them. The problem is that the checks were
performed in the wrong order, leading to a race condition. If the
sender attached, sent a message, and detached after the receiver
called shm_mq_get_sender and before the receiver called
shm_mq_counterparty_gone, we'd incorrectly return SHM_MQ_DETACHED
before all messages were read. Repair by reversing the order of
operations, and add a long comment explaining why this new logic is
(hopefully) correct.
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.h')
0 files changed, 0 insertions, 0 deletions