diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-01 11:37:46 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-01 11:37:46 -0500 |
| commit | 8f72a5704854d292065886eb47ba18fbd504113e (patch) | |
| tree | 5abf1c9c9de417cf9830fd9890a80e124bbc0236 /contrib/postgres_fdw/deparse.c | |
| parent | 1437824564f47e8e7641e98958a08c1544b6b8f4 (diff) | |
| download | postgresql-8f72a5704854d292065886eb47ba18fbd504113e.tar.gz postgresql-8f72a5704854d292065886eb47ba18fbd504113e.zip | |
Fix format_type() to restore its old behavior.
Commit a26116c6c accidentally changed the behavior of the SQL format_type()
function while refactoring. For the reasons explained in that function's
comment, a NULL typemod argument should behave differently from a -1
argument. Since we've managed to break this, add a regression test
memorializing the intended behavior.
In passing, be consistent about the type of the "flags" parameter.
Noted by Rushabh Lathia, though I revised the patch some more.
Discussion: https://postgr.es/m/CAGPqQf3RB2q-d2Awp_-x-Ur6aOxTUwnApt-vm-iTtceZxYnePg@mail.gmail.com
Diffstat (limited to 'contrib/postgres_fdw/deparse.c')
| -rw-r--r-- | contrib/postgres_fdw/deparse.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 8cd5843885e..6e2fa1420c4 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -854,7 +854,7 @@ foreign_expr_walker(Node *node, static char * deparse_type_name(Oid type_oid, int32 typemod) { - uint8 flags = FORMAT_TYPE_TYPEMOD_GIVEN; + bits16 flags = FORMAT_TYPE_TYPEMOD_GIVEN; if (!is_builtin(type_oid)) flags |= FORMAT_TYPE_FORCE_QUALIFY; |