diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-01-23 03:36:55 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2022-01-23 04:05:08 +0100 |
| commit | 72ac4d71b54fdac5efc9ecfc23663f26c20ddcf9 (patch) | |
| tree | 2d5e366382a0b4bd92b3d5b9f3fd2fc704724724 | |
| parent | a192243c75be0f142f829b3e73548bc7cbd3b90d (diff) | |
| download | postgresql-72ac4d71b54fdac5efc9ecfc23663f26c20ddcf9.tar.gz postgresql-72ac4d71b54fdac5efc9ecfc23663f26c20ddcf9.zip | |
Correct type of front_pathkey to PathKey
In sort_inner_and_outer we iterate a list of PathKey elements, but the
variable is declared as (List *). This mistake is benign, because we
only pass the pointer to lcons() and never dereference it.
This exists since ~2004, but it's confusing. So fix and backpatch to all
supported branches.
Backpatch-through: 10
Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com
| -rw-r--r-- | src/backend/optimizer/path/joinpath.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c index c5640b4d3a1..6e25fbeba1c 100644 --- a/src/backend/optimizer/path/joinpath.c +++ b/src/backend/optimizer/path/joinpath.c @@ -1243,7 +1243,7 @@ sort_inner_and_outer(PlannerInfo *root, foreach(l, all_pathkeys) { - List *front_pathkey = (List *) lfirst(l); + PathKey *front_pathkey = (PathKey *) lfirst(l); List *cur_mergeclauses; List *outerkeys; List *innerkeys; |