diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2018-11-03 11:08:03 +1300 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2018-11-03 11:08:03 +1300 |
| commit | fd6449aa38759cc35c32c1d5bf87c516ba6385c8 (patch) | |
| tree | 4e2cbd5ae8c12249cad29be1962b663c255e1a6a | |
| parent | ca49b5ca5af35bc1ee199105cec94fb86ad9a59b (diff) | |
| download | postgresql-fd6449aa38759cc35c32c1d5bf87c516ba6385c8.tar.gz postgresql-fd6449aa38759cc35c32c1d5bf87c516ba6385c8.zip | |
Fix NULL handling in multi-batch Parallel Hash Left Join.
NULL keys in left joins were skipped when building batch files.
Repair, by making the keep_nulls argument to ExecHashGetHashValue()
depend on whether this is a left outer join, as we do in other
paths.
Bug #15475. Thinko in 1804284042e. Back-patch to 11.
Reported-by: Paul Schaap
Diagnosed-by: Andrew Gierth
Dicussion: https://postgr.es/m/15475-11a7a783fed72a36%40postgresql.org
| -rw-r--r-- | src/backend/executor/nodeHashjoin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c index dd94cffbd18..5922e60eed6 100644 --- a/src/backend/executor/nodeHashjoin.c +++ b/src/backend/executor/nodeHashjoin.c @@ -1395,7 +1395,7 @@ ExecParallelHashJoinPartitionOuter(HashJoinState *hjstate) if (ExecHashGetHashValue(hashtable, econtext, hjstate->hj_OuterHashKeys, true, /* outer tuple */ - false, /* outer join, currently unsupported */ + HJ_FILL_OUTER(hjstate), &hashvalue)) { int batchno; |