From 648b5b6e50c52dedaa7a7437cbcf07651b7f5d74 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 11 May 2026 17:29:56 +0200 Subject: [PATCH] CLEANUP: regex: pre-initialize error variable in regex_comp() to calm analysis In regex_comp(), the error variable is either a const char* (USE_PCRE) or a a uchar[] (USE_PCRE2), and navigating through the ifdefs is quite a mess, making it hard to figure if it's always properly initialized when printing an error message. Let's just preset it to NULL to clarify what comes from where. --- src/regex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/regex.c b/src/regex.c index c9d5258c4..524afc925 100644 --- a/src/regex.c +++ b/src/regex.c @@ -304,7 +304,7 @@ struct my_regex *regex_comp(const char *str, int cs, int cap, char **err) struct my_regex *regex = NULL; #if defined(USE_PCRE) || defined(USE_PCRE_JIT) int flags = 0; - const char *error; + const char *error = NULL; int erroffset; #elif defined(USE_PCRE2) || defined(USE_PCRE2_JIT) int flags = 0; -- 2.47.3