From e7ea1a7771ec8974b0f0a0a7362ff35067cdda86 Mon Sep 17 00:00:00 2001
From: Igor Sysoev <igor@sysoev.ru>
Date: Thu, 19 Nov 2015 18:00:33 +0300
Subject: [PATCH] Using pcre_free() instead of pcre_free_study(). Other regexp
 small miscellaneous fixes.

---
 njs/njs_regexp.c         | 28 +++++++++++++++++++++-------
 njs/njs_regexp_pattern.h |  2 +-
 2 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/njs/njs_regexp.c b/njs/njs_regexp.c
index 978aac11..3829fd20 100644
--- a/njs/njs_regexp.c
+++ b/njs/njs_regexp.c
@@ -203,10 +203,15 @@ njs_regexp_pattern_create(njs_vm_t *vm, u_char *start, size_t length,
         return NULL;
     }
 
+    pattern->flags = size;
+    pattern->code[0] = NULL;
+    pattern->code[1] = NULL;
+    pattern->extra[0] = NULL;
+    pattern->extra[1] = NULL;
+    pattern->next = NULL;
+
     p = (u_char *) pattern + sizeof(njs_regexp_pattern_t);
     pattern->source = p;
-    pattern->next = NULL;
-    pattern->flags = size;
 
     *p++ = '/';
     p = memcpy(p, start, length);
@@ -214,8 +219,6 @@ njs_regexp_pattern_create(njs_vm_t *vm, u_char *start, size_t length,
     end = p;
     *p++ = '\0';
 
-    pattern->ncaptures = 0;
-
     pattern->global = ((flags & NJS_REGEXP_GLOBAL) != 0);
     if (pattern->global) {
         *p++ = 'g';
@@ -256,7 +259,7 @@ njs_regexp_pattern_create(njs_vm_t *vm, u_char *start, size_t length,
 
     if (nxt_fast_path(ret >= 0)) {
 
-        if (nxt_slow_path((unsigned) ret != pattern->ncaptures)) {
+        if (nxt_slow_path((u_int) ret != pattern->ncaptures)) {
             nxt_thread_log_error(NXT_LOG_ERR, "numbers of captures in byte "
                            "and UTF-8 versions of RegExp \"%s\" vary: %d vs %d",
                            &pattern->source[1], pattern->ncaptures, ret);
@@ -735,11 +738,22 @@ njs_regexp_prototype_hash(njs_vm_t *vm, nxt_lvlhsh_t *hash)
 void
 njs_regexp_pattern_free(njs_regexp_pattern_t *pattern)
 {
+    /*
+     * pcre_free() is enough to free PCRE extra study data.
+     * pcre_free_study() is required for JIT optimization, pcreapi(3):
+     *
+     *   When you are finished with a pattern,  you can free  the memory used
+     *   for the study data by calling  pcre_free_study().  This function was
+     *   added to the API for release 8.20.  For earlier versions, the memory
+     *   could be freed with pcre_free(), just like the pattern itself.  This
+     *   will still work in cases where JIT optimization is not used,  but it
+     *   is advisable to change to the new function when convenient.
+     */
     while (pattern != NULL) {
-        pcre_free_study(pattern->extra[0]);
+        pcre_free(pattern->extra[0]);
         pcre_free(pattern->code[0]);
 
-        pcre_free_study(pattern->extra[1]);
+        pcre_free(pattern->extra[1]);
         pcre_free(pattern->code[1]);
 
         pattern = pattern->next;
diff --git a/njs/njs_regexp_pattern.h b/njs/njs_regexp_pattern.h
index ee4f47e8..79ce501e 100644
--- a/njs/njs_regexp_pattern.h
+++ b/njs/njs_regexp_pattern.h
@@ -13,6 +13,7 @@
 struct njs_regexp_pattern_s {
     pcre                  *code[2];
     pcre_extra            *extra[2];
+    njs_regexp_pattern_t  *next;
     /*
      * A pattern source is used by RegExp.toString() method and
      * RegExp.source property.  So it is is stored in form "/pattern/flags"
@@ -22,7 +23,6 @@ struct njs_regexp_pattern_s {
      * in flags field.
      */
     u_char                *source;
-    njs_regexp_pattern_t  *next;
 
 #if (NXT_64BIT)
     uint32_t              ncaptures;
-- 
2.47.3