From a0fa577070bdeaf5f1c559eee0fa435122d5d5c6 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 7 Apr 2023 15:06:42 +0200 Subject: [PATCH] CLEANUP: tcpcheck: remove the only occurrence of sprintf() in the code There's a single sprintf() in the whole code, in the "option smtpchk" parser in tcpcheck.c. Let's turn it to a safer snprintf(). --- src/tcpcheck.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tcpcheck.c b/src/tcpcheck.c index 085f42768..55fd190cf 100644 --- a/src/tcpcheck.c +++ b/src/tcpcheck.c @@ -4262,9 +4262,10 @@ int proxy_parse_smtpchk_opt(char **args, int cur_arg, struct proxy *curpx, const if (*args[cur_arg] && *args[cur_arg+1] && (strcmp(args[cur_arg], "EHLO") == 0 || strcmp(args[cur_arg], "HELO") == 0)) { /* + space (1) + + null byte (1) */ - cmd = calloc(strlen(args[cur_arg]) + 1 + strlen(args[cur_arg+1]) + 1, sizeof(*cmd)); + size_t len = strlen(args[cur_arg]) + 1 + strlen(args[cur_arg+1]) + 1; + cmd = calloc(len, 1); if (cmd) - sprintf(cmd, "%s %s", args[cur_arg], args[cur_arg+1]); + snprintf(cmd, len, "%s %s", args[cur_arg], args[cur_arg+1]); } else { /* this just hits the default for now, but you could potentially expand it to allow for other stuff -- 2.47.3