From 8b673f0fe3dfb16f509cccd5b84024b6304ddb2c Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Sun, 22 Aug 2021 13:36:11 +0200 Subject: [PATCH] CLEANUP: ssl: remove useless check on p in openssl_version_parser() Remove a useless check on a pointer which reports a NULL dereference on coverity. Fixes issue #1358. --- src/ssl_utils.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/ssl_utils.c b/src/ssl_utils.c index 20dcdb90c..578212182 100644 --- a/src/ssl_utils.c +++ b/src/ssl_utils.c @@ -373,11 +373,9 @@ unsigned int openssl_version_parser(const char *version) if (!strncmp(p, "beta", 4)) { p += 4; - if (p) { - status = strtol(p, &end, 10); - if (status > 14) - goto error; - } + status = strtol(p, &end, 10); + if (status > 14) + goto error; } } else { /* that's a patch release */ -- 2.47.3