From 87a0db9993b057b1fe7309ddedda7de0f55d6be2 Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Fri, 10 Apr 2020 17:13:09 +0200 Subject: [PATCH] BUG/MINOR: ssl: ssl_conf always set to NULL on crt-list parsing When reading a crt-list file, the SSL options betweeen square brackets are parsed, however the calling function sets the ssl_conf ptr to NULL leading to all options being ignored, and a memory leak. This is a remaining of the previous code which was forgotten. This bug was introduced by 97b0810 ("MINOR: ssl: split the line parsing of the crt-list"). --- src/ssl_sock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/ssl_sock.c b/src/ssl_sock.c index af80a757f..1cd701e61 100644 --- a/src/ssl_sock.c +++ b/src/ssl_sock.c @@ -4862,7 +4862,6 @@ static int crtlist_parse_file(char *file, struct bind_conf *bind_conf, struct pr char *end; char *line = thisline; char *crt_path; - struct ssl_bind_conf *ssl_conf = NULL; struct ckch_store *ckchs; linenum++; @@ -4925,7 +4924,6 @@ static int crtlist_parse_file(char *file, struct bind_conf *bind_conf, struct pr goto error; entry->node.key = ckchs; - entry->ssl_conf = ssl_conf; entry->crtlist = newlist; ebpt_insert(&newlist->entries, &entry->node); LIST_ADDQ(&newlist->ord_entries, &entry->by_crtlist); -- 2.47.3