From 79fee6aa7accf588b52c10155748f1d6de9d72ac Mon Sep 17 00:00:00 2001 From: Baptiste Assmann Date: Fri, 11 Mar 2016 17:10:04 +0100 Subject: [PATCH] MINOR: cfgparse: warn when uid parameter is not a number Currently, no warning are emitted when the uid is not a number. Purpose of this warning is to let admins know they their configuration won't be applied as expected. --- src/cfgparse.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index c55a56161..1a2c1ea04 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -1075,7 +1075,12 @@ int cfg_parse_global(const char *file, int linenum, char **args, int kwm) err_code |= ERR_ALERT | ERR_FATAL; goto out; } - global.uid = atol(args[1]); + if (strl2irc(args[1], strlen(args[1]), &global.uid) != 0) { + Warning("parsing [%s:%d] : uid: string '%s' is not a number.\n | You might want to use the 'user' parameter to use a system user name.\n", file, linenum, args[1]); + err_code |= ERR_WARN; + goto out; + } + } else if (!strcmp(args[0], "gid")) { if (alertif_too_many_args(1, file, linenum, args, &err_code)) -- 2.47.3