From 009c32d863d74d10a209a43242e0279278a3957c Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Mon, 11 May 2026 14:44:12 +0200 Subject: [PATCH] BUG/MINOR: mux-h1: only check h1s if not NULL Since we can emit glitches during an H2 upgrade, we no longer have a guaranteed h1s, so _h1_report_glitch() must check h1s before dereferencing it. No backport is needed as this arrived in 3.4-dev11 with commit 72fd357814 ("MEDIUM: mux-h1: Return an error on h2 upgrade attempts if not allowed"). --- src/mux_h1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mux_h1.c b/src/mux_h1.c index b5c0fd3a5..f8eaaccfb 100644 --- a/src/mux_h1.c +++ b/src/mux_h1.c @@ -536,7 +536,8 @@ static inline int _h1_report_glitch(struct h1c *h1c, int increment) /* at 75% of the threshold, we switch to close mode * to force clients to periodically reconnect. */ - h1c->h1s->flags = (h1c->h1s->flags & ~H1S_F_WANT_MSK) | H1S_F_WANT_CLO; + if (h1c->h1s) + h1c->h1s->flags = (h1c->h1s->flags & ~H1S_F_WANT_MSK) | H1S_F_WANT_CLO; /* at 100% of the threshold and excess of CPU usage we also * actively kill the connection. -- 2.47.3