]>
git.kaiwu.me - njs.git/log
Dmitry Volyntsev [Wed, 17 Sep 2025 22:34:19 +0000 (15:34 -0700)]
Modules: fixed building when http_ssl and stream_ssl unavailable.
This fixes issue introduced in
7b3c8a66 .
Dmitry Volyntsev [Wed, 17 Sep 2025 01:28:05 +0000 (18:28 -0700)]
Fixed build with gcc-15 and -O3.
build/src/njs_object.dep -MT build/src/njs_object.o \ src/njs_object.c
In file included from src/njs_main.h:18, from src/njs_object.c:8: In
function ‘njs_utf8_copy’, inlined from ‘njs_object_enumerate_string’ at
src/njs_object.c:769:21: src/njs_utf8.h:115:20: error: writing 1 byte
into a region of size 0 [-Werror=stringop-overflow=] 115 |
*dst++ = c; | ~~~~~~~^~~ src/njs_object.c: In function
‘njs_object_enumerate_string’: src/njs_object.c:719:24: note: at offset
4 into destination object ‘buf’ of size 4 719 | u_char
buf[4], *c; | ^~~ In function ‘njs_utf8_copy’,
inlined from ‘njs_object_enumerate_string’ at src/njs_object.c:769:21:
src/njs_utf8.h:115:20: error: writing 1 byte into a region of size 0
[-Werror=stringop-overflow=]
GCC-15 does not know that the loop in njs_utf8_copy() is bounded
because the input is a valid UTF-8 here.
This fixes #967 issue on Github.
Dmitry Volyntsev [Thu, 4 Sep 2025 03:27:16 +0000 (20:27 -0700)]
Fetch: added keepalive support for ngx.fetch() API.
This closes #957 feature request on Github.
Dmitry Volyntsev [Sat, 13 Sep 2025 02:10:32 +0000 (19:10 -0700)]
Fetch: added parsing of HTTP version.
Dmitry Volyntsev [Thu, 4 Sep 2025 05:44:04 +0000 (22:44 -0700)]
Modules: simplified access to nginx values from JS engines.
Dmitry Volyntsev [Tue, 26 Aug 2025 21:22:19 +0000 (14:22 -0700)]
QuickJS: added njs.on('exit') API support.
This closes #955 issue on Github.
Dmitry Volyntsev [Fri, 29 Aug 2025 02:15:01 +0000 (19:15 -0700)]
QuickJS: removed extra copy of body argument in ngx.fetch().
Dmitry Volyntsev [Thu, 28 Aug 2025 22:20:31 +0000 (15:20 -0700)]
QuickJS: fixed potential heap-use-after-free.
Previously in QuickJS engine, fields allocated from memory pool linked
to QuickJS engine lifetime were stored in nginx data structs.
This causes a heap-use-after-free if QuickJS engine is destroyed
earlier than a last access from nginx. For example, it becomes
visible when moving NJS cleanup handler from pool->cleanup to
r->cleanup.
The fix is to only store references in nginx objects allocated from
nginx memory pool.
Dmitry Volyntsev [Thu, 28 Aug 2025 23:29:22 +0000 (16:29 -0700)]
QuickJS: freeing temporary strings.
Dmitry Volyntsev [Tue, 26 Aug 2025 05:26:24 +0000 (22:26 -0700)]
QuickJS: using enum instead of manual opaque id table.
Vadim Zhestikov [Fri, 29 Aug 2025 16:42:18 +0000 (09:42 -0700)]
QuickJS: fix nginx configure with not configured njs module.
This fixes issue #960 which was introduced in
8259f9a .
Dmitry Volyntsev [Tue, 19 Aug 2025 04:21:09 +0000 (21:21 -0700)]
Modules: optimized memory consumption while streaming in qjs.
This allows to stream long tcp streams or large http response bodies
with low memory consumption.
This works only for qjs engine, because njs has no GC.
This fixes #943 issue on Github.
Dmitry Volyntsev [Thu, 14 Aug 2025 06:19:46 +0000 (23:19 -0700)]
Modules: removing extra copy while streaming in qjs.
Dmitry Volyntsev [Wed, 20 Aug 2025 00:16:22 +0000 (17:16 -0700)]
Tests: added TypedArray test for js_filter in stream.
Dmitry Volyntsev [Mon, 25 Aug 2025 23:47:43 +0000 (16:47 -0700)]
Fixed building QuickJS support with clang 19.
checking for QuickJS library -lquickjs In file included from
build/autotest.c:6:
/home/xeioex/workspace/nginx/nginScript/quickjs/quickjs.h:1052:34:
error: cast from 'JSCFunctionMagic *' (aka 'struct JSValue (*)(struct
JSContext *, struct JSValue, int, struct JSValue *, int)') to
'JSCFunction *' (aka 'struct JSValue (*)(struct JSContext *, struct
JSValue, int, struct JSValue *)') converts to incompatible function type
[-Werror,-Wcast-function-type-mismatch] 1052 | return
JS_NewCFunction2(ctx, (JSCFunction *)func, name, length, cproto, magic);
-Wcast-function-type-mismatch become enabled by -Werror since
clang 19.
Dmitry Volyntsev [Sat, 16 Aug 2025 00:28:47 +0000 (17:28 -0700)]
Modules: fixed incorrect config rejections introduced in
d157f56 .
d157f56 introduced configure time checks for js_set and js_periodic
directives. It turned out to be too strict.
The fix is to remove them completely as there is no way to track
variable usage context in configure time.
Dmitry Volyntsev [Tue, 12 Aug 2025 06:26:12 +0000 (23:26 -0700)]
Modules: added configure time check when "js_import" is not defined.
Dmitry Volyntsev [Tue, 12 Aug 2025 01:55:18 +0000 (18:55 -0700)]
Modules: fixed merging of js_path directives.
The issue initially appeared in
1b54abb (0.7.7).
Dmitry Volyntsev [Mon, 11 Aug 2025 23:25:47 +0000 (16:25 -0700)]
Change: increasing the default stack size to 160k.
This change allows EarleyBoyer benchmark from
arewefastyet/benchmarks/v8-v7 to pass with default settings.
Previous commit
5e9a6d5 (v0.7.9) reduced the stack size to prevent stack
overflow when compiling with -O0 in computed goto mode, where native
stack frames for njs_vmcode_interpreter() consume ~80KB each. To address
this, we now set a lower maximum stack size specifically for unit tests.
This fixes #939 issue on Github.
Vadim Zhestikov [Fri, 8 Aug 2025 00:41:09 +0000 (17:41 -0700)]
Added CLA workflow.
Vadim Zhestikov [Fri, 11 Jul 2025 22:51:14 +0000 (15:51 -0700)]
Removed remnants of level hash.
Level hash has not been compiled since
e64a376 (0.8.1) when flat hash was
introduced. However, the compatibility layer remained to reduce the diff.
Dmitry Volyntsev [Sat, 12 Jul 2025 01:26:19 +0000 (18:26 -0700)]
Version bump.
Dmitry Volyntsev [Wed, 9 Jul 2025 21:34:05 +0000 (14:34 -0700)]
Version 0.9.1.
Dmitry Volyntsev [Thu, 10 Jul 2025 17:40:05 +0000 (10:40 -0700)]
Fixed property set for objects with a TypedArray in prototype.
The issue was introduced in
2f288a9c .
Vadim Zhestikov [Fri, 6 Jun 2025 23:52:57 +0000 (16:52 -0700)]
Optimized memory consumption by object hash.
The new hash takes 42% less memory per element.
Vadim Zhestikov [Sun, 6 Jul 2025 18:30:38 +0000 (11:30 -0700)]
Replaced constant by sizeof value.
Vadim Zhestikov [Thu, 3 Jul 2025 21:14:43 +0000 (14:14 -0700)]
Improved String.prototype.concat() with scalar values.
Dmitry Volyntsev [Tue, 8 Jul 2025 05:40:45 +0000 (22:40 -0700)]
Fixed NULL pointer dereference when processing If-* headers.
Previously, when processing requests with If-Match and
If-Unmodified-Since headers worker process crashed.
For example with the following code:
try { r.return(200) }
catch (e) { r.internalRedirect() }
The fix is to disable not_modified filter as it was done in
nginx perl module nginx/nginx@
d9887ee2 .
Dmitry Volyntsev [Thu, 3 Jul 2025 23:53:33 +0000 (16:53 -0700)]
Fixed RegExp compilation after
17124c81 .
Previously, heap-buffer-overflow happened due to incorrect copying of
[...] regexp parts.
Found by OSS-Fuzz.
Vadim Zhestikov [Fri, 27 Jun 2025 16:45:48 +0000 (09:45 -0700)]
Removed not used njs_scope_create_index_value().
Vadim Zhestikov [Mon, 16 Jun 2025 21:33:05 +0000 (14:33 -0700)]
Removed useless njs_value_assign() call.
Vadim Zhestikov [Fri, 6 Jun 2025 23:45:15 +0000 (16:45 -0700)]
Simplified njs_object_prop_t.
Removed enum_in_object_hash which is only set when prop->type is
NJS_WHITEOUT and this check can be used instead.
Vadim Zhestikov [Thu, 12 Jun 2025 15:34:17 +0000 (08:34 -0700)]
Ignoring previous value in njs_flathsh_insert().
Previously, fhq->value was set to a previous value if the value existed.
This is not used anymore in the code.
Vadim Zhestikov [Wed, 25 Jun 2025 18:50:25 +0000 (11:50 -0700)]
Released temporary template literal memory.
Vadim Zhestikov [Tue, 24 Jun 2025 00:44:57 +0000 (17:44 -0700)]
Improved memory consumption of String.prototype.concat() with numbers.
Vadim Zhestikov [Mon, 23 Jun 2025 19:33:18 +0000 (12:33 -0700)]
Improved memory consumption for concatenation of numbers and strings.
Xiaobo Liu [Tue, 1 Jul 2025 09:31:16 +0000 (17:31 +0800)]
Fixed invalid link in README.md.
Dmitry Volyntsev [Tue, 1 Jul 2025 01:30:03 +0000 (18:30 -0700)]
Fixed regexp compilation of patterns with escaped '[' characters.
This fixes #934 issue on Github.
Dmitry Volyntsev [Wed, 2 Jul 2025 06:01:57 +0000 (23:01 -0700)]
Modules: fixed qjs engine after bellard/quickjs@
458c34d2 .
Object leaks:
ADDRESS REFS SHRF PROTO CONTENT
0x512000007fc0 1 [module]
nginx: quickjs.c:1967: JS_FreeRuntime: Assertion `list_empty(&rt->gc_obj_list)' failed.
After bellard/quickjs@
458c34d2 modules are treated as GC objects and
tracked in rt->gc_obj_list. Intermediary module object loaded in
ngx_qjs_clone() using JS_ReadObject() needed to be freed for proper
ref_count accounting.
Dmitry Volyntsev [Tue, 17 Jun 2025 02:36:35 +0000 (19:36 -0700)]
Fetch: fixed handling of Content-Length header when body is provided.
body value length takes precedence over Content-Length from header list.
https://fetch.spec.whatwg.org/#http-network-or-cache-fetch
Let contentLength be httpRequest’s body’s length, if httpRequest’s body
is non-null; otherwise null.
Let contentLengthHeaderValue be null.
If httpRequest’s body is null and httpRequest’s method is `POST` or
`PUT`, then set contentLengthHeaderValue to `0`.
If contentLength is non-null, then set contentLengthHeaderValue to
contentLength, serialized and isomorphic encoded.
If contentLengthHeaderValue is non-null, then append (`Content-Length`,
contentLengthHeaderValue) to httpRequest’s header list.
This fixes #930 issue in Github.
Dmitry Volyntsev [Tue, 17 Jun 2025 01:16:46 +0000 (18:16 -0700)]
Types: added TS definitions for WebCrypto ECDH.
Dmitry Volyntsev [Tue, 17 Jun 2025 01:03:41 +0000 (18:03 -0700)]
Types: updated TS definitions.
Dmitry Volyntsev [Sat, 14 Jun 2025 03:19:36 +0000 (20:19 -0700)]
Parser: unused strict_semicolon cleanup.
Dmitry Volyntsev [Fri, 13 Jun 2025 00:33:35 +0000 (17:33 -0700)]
Parser: simplifed working with function variables.
Dmitry Volyntsev [Wed, 11 Jun 2025 23:17:42 +0000 (16:17 -0700)]
Fixed frame saving for awaited function with closures.
The issue was introduced in
6335367 (0.7.0).
This fixes #530 issue on Github.
Dmitry Volyntsev [Tue, 10 Jun 2025 01:38:15 +0000 (18:38 -0700)]
Moving child function declaration instantiation to bytecode.
Children functions need to be hoisted and instantiated at the beginning
of a function call. Previously, it was done as a part of C code
that implements JS function call.
Now, each child function is instantiated by FUNCTION instruction at a
function prelude. This makes global and function code similar, which in
turn allows to get rid of FUNCTION COPY instruction which was only
needed for global code.
Dmitry Volyntsev [Fri, 13 Jun 2025 00:54:43 +0000 (17:54 -0700)]
Tests: tuned periodic test for delays.
Dmitry Volyntsev [Fri, 13 Jun 2025 00:20:07 +0000 (17:20 -0700)]
Fixed handling of detached buffer for typed arrays.
Dmitry Volyntsev [Thu, 12 Jun 2025 22:34:39 +0000 (15:34 -0700)]
Fixed %TypedArray%.prototype.slice() with overlapping buffers.
Dmitry Volyntsev [Thu, 12 Jun 2025 22:16:41 +0000 (15:16 -0700)]
Fixed %TypedArray%.from() with buffer is detached by mapper.
Orgad Shaneh [Mon, 9 Jun 2025 13:59:22 +0000 (16:59 +0300)]
Removed NGX_MAX_PATH define.
Already defined in ngx_files.h (included from ngx_core.h).
Dmitry Volyntsev [Thu, 5 Jun 2025 06:07:11 +0000 (23:07 -0700)]
Fixed compilation with old gcc.
This fixed compilation issues with gcc-4.1.
Dmitry Volyntsev [Thu, 5 Jun 2025 05:54:54 +0000 (22:54 -0700)]
Fixed constant is too large for 'long' warning on mips -mabi=n32.
Prodded by Orgad Shaneh.
Dmitry Volyntsev [Tue, 3 Jun 2025 02:08:27 +0000 (19:08 -0700)]
Fixed gcc compilation with O3 optimization level.
Dmitry Volyntsev [Wed, 4 Jun 2025 05:37:32 +0000 (22:37 -0700)]
Improved README.md clarity with angle bracket explanations.
Dmitry Volyntsev [Tue, 3 Jun 2025 00:18:22 +0000 (17:18 -0700)]
Fixed Function constructor template injection.
The Function constructor uses a `(function(<args>) {<body>})` template
to construct new functions. This approach was vulnerable to template
injection where malicious code could close the function body early.
This fixes issue #921.
Vadim Zhestikov [Wed, 28 May 2025 16:16:38 +0000 (09:16 -0700)]
Fixed segfault at error message in njs_property_query().
The issue was introduced in
b28e50b1 (0.9.0).
This closes #918 issue on Github.
Dmitry Volyntsev [Thu, 22 May 2025 00:10:15 +0000 (17:10 -0700)]
QuickJS: added memory limit check for reuse queue.
Dmitry Volyntsev [Thu, 15 May 2025 01:16:15 +0000 (18:16 -0700)]
Modules: added state file for the shared dictionary.
A new optional state parameter is added for js_shared_dict_zone
directive. state parameter specifies a file that keeps the current state
of the shared dict in the JSON format and makes it persistent
across nginx restarts.
This closes #709 feature request on Github.
Dmitry Volyntsev [Fri, 16 May 2025 00:24:25 +0000 (17:24 -0700)]
Modules: engine independent method to add entries to a shared dict.
Dmitry Volyntsev [Fri, 16 May 2025 00:01:25 +0000 (17:01 -0700)]
Modules: replaced njs_str_t with ngx_str_t in the shared dictionary.
This is a preparatory patch for upcoming changes to unify common code
for njs and QuickJS engines.
Dmitry Volyntsev [Thu, 15 May 2025 02:36:33 +0000 (19:36 -0700)]
Modules: introduced NGX_CHB_CTX_INIT().
Dmitry Volyntsev [Thu, 15 May 2025 01:00:23 +0000 (18:00 -0700)]
Modules: separating different init worker components.
Dmitry Volyntsev [Tue, 20 May 2025 01:53:00 +0000 (18:53 -0700)]
Tests: removed leftover engine checks.
Dmitry Volyntsev [Mon, 19 May 2025 21:58:12 +0000 (14:58 -0700)]
WebCrypto: fixed issue introduced in
637fc26e .
Found by Clang static analyzer.
Dmitry Volyntsev [Wed, 14 May 2025 02:08:16 +0000 (19:08 -0700)]
WebCrypto: improved working with curve constants.
In crypto.subtle.generateKey().
Dmitry Volyntsev [Fri, 9 May 2025 00:13:01 +0000 (17:13 -0700)]
WebCrypto: added ECDH support.
Dmitry Volyntsev [Fri, 9 May 2025 01:03:21 +0000 (18:03 -0700)]
WebCrypto: making SHA-256 the default hash algorithm.
Dmitry Sviridkin [Thu, 15 May 2025 12:55:13 +0000 (13:55 +0100)]
Add missing null checks for promise code.
Zhidao HONG [Tue, 22 Apr 2025 02:56:27 +0000 (10:56 +0800)]
Fetch: QuickJS support.
Zhidao HONG [Mon, 21 Apr 2025 17:09:15 +0000 (01:09 +0800)]
Fetch: unify string type to support both njs and QuickJS.
Zhidao HONG [Mon, 21 Apr 2025 17:04:31 +0000 (01:04 +0800)]
Fetch: separated ngx_js_http_* from ngx_js_fetch_*.
Dmitry Volyntsev [Thu, 8 May 2025 03:49:21 +0000 (20:49 -0700)]
WebCrypto: fixed extractable handling for crypto.subtle.deriveKey().
Dmitry Volyntsev [Thu, 8 May 2025 02:11:24 +0000 (19:11 -0700)]
WebCrypto: added support for HMAC as derivedKeyAlgorithm.
In crypto.subtle.deriveKey().
This closes #905 issue on Github.
Dmitry Volyntsev [Thu, 8 May 2025 16:25:24 +0000 (09:25 -0700)]
Version bump.
Vadim Zhestikov [Mon, 5 May 2025 19:38:32 +0000 (12:38 -0700)]
Version 0.9.0.
Dmitry Volyntsev [Mon, 5 May 2025 15:53:19 +0000 (08:53 -0700)]
HTTP: fixed GCC 15 build with -Wunterminated-string-initialization.
ngx_http_js_module.c:936:22: error: initializer-string for array of ‘char’ truncates NUL terminator
but destination lacks ‘nonstring’ attribute (16 chars into 15 available) [-Werror=unterminated-string-initialization]
936 | .value = "PeriodicSession",
| ^~~~~~~~~~~~~~~~~
Dmitry Volyntsev [Fri, 2 May 2025 00:05:56 +0000 (17:05 -0700)]
Fixed GCC 15 build with -Wunterminated-string-initialization.
In file included from src/njs_main.h:48,
from src/njs_diyfp.c:12:
src/njs_string.h: In function ‘njs_string_encode’:
src/njs_string.h:229:36: error: initializer-string for array of ‘unsigned char’
truncates NUL terminator but destination lacks ‘nonstring’ attribute (
17 chars into 16 available) [-Werror=unterminated-string-initialization]
229 | static const u_char hex[16] = "
0123456789ABCDEF ";
Dmitry Volyntsev [Thu, 1 May 2025 16:06:25 +0000 (09:06 -0700)]
Tests: fixed js_body_filter.t.
The
1496ed3f commit made visible a problem with the fragile filter tests
which depend on the exact sequence of data chunks. The fix is to use
perl http server to ensure the order.
Vadim Zhestikov [Wed, 30 Apr 2025 21:20:31 +0000 (14:20 -0700)]
Fixed regexp undefined value of captured group.
Found by OSS-Fuzz.
Dmitry Volyntsev [Thu, 1 May 2025 01:32:39 +0000 (18:32 -0700)]
Using invalid UTF-8 string as atom number 0.
This prevents a clash with possible valid UTF-8 strings.
Dmitry Volyntsev [Thu, 1 May 2025 01:23:20 +0000 (18:23 -0700)]
Fixed building with --debug=YES after
b28e50b1 .
In file included from src/njs_main.h:37,
from src/njs_diyfp.c:12:
src/njs_atom.h: In function ‘njs_atom_to_value’:
src/njs_atom.h:54:31: error: invalid use of incomplete typedef
‘njs_flathsh_descr_t’ {aka ‘struct njs_flathsh_descr_s’}
54 | njs_assert(atom_id < h->elts_count);
| ^~
src/njs_assert.h:14:15: note: in definition of macro ‘njs_assert’
Dmitry Volyntsev [Tue, 29 Apr 2025 01:34:29 +0000 (18:34 -0700)]
Tests: improved js_body_filter.t tests.
Dropping Content-Length header in locations where response body
length is modified. This is not strictly needed for the test itself,
but can serve as an example for a typical body modification task.
Dmitry Volyntsev [Tue, 29 Apr 2025 01:28:08 +0000 (18:28 -0700)]
Tests: fixed js_body_filter.t tests.
Previously, '|' was used incorrectly in test match pattern.
Dmitry Volyntsev [Sat, 22 Mar 2025 05:52:55 +0000 (22:52 -0700)]
Introduced NJS_VMCODE_PROPERTY_ATOM_SET instruction.
Dmitry Volyntsev [Wed, 26 Mar 2025 07:23:23 +0000 (00:23 -0700)]
Introduced NJS_VMCODE_PROPERTY_ATOM_GET instruction.
Vadim Zhestikov [Thu, 29 Aug 2024 05:03:14 +0000 (22:03 -0700)]
Refactored working with built-in strings, symbols and small integers.
- Implemented atom IDs for strings, symbols and small numbers, enabling
equality checks via ID comparison
- Optimized string operations for faster property lookups and comparisons
- Removed short string inlining from njs_value_t structure
Performance improvements (arewefastyet/benchmarks/v8-v7 benchmark):
- Richards: +57% (631 → 989)
- Crypto: +7% (1445 → 1551)
- RayTrace: +37% (562 → 772)
- NavierStokes: +20% (2062 → 2465)
- Overall score: +29% (1014 → 1307)
In collaboration with Dmitry Volyntsev.
Dmitry Volyntsev [Mon, 21 Apr 2025 16:41:46 +0000 (09:41 -0700)]
Test262: fixed mktemp format on OpenBSD.
mktemp: insufficient number of Xs in template `/tmp/njs_test.XXX'
Zhidao HONG [Mon, 21 Apr 2025 15:37:49 +0000 (23:37 +0800)]
Replaced vm with mp in NJS_CHB_MP_INIT().
Zhidao HONG [Fri, 11 Apr 2025 14:43:31 +0000 (22:43 +0800)]
Fetch: refactored out ngx_js_http_resolve().
Zhidao HONG [Fri, 11 Apr 2025 14:02:16 +0000 (22:02 +0800)]
Fetch: refactored out ngx_js_http_close_peer().
Zhidao HONG [Fri, 11 Apr 2025 13:59:16 +0000 (21:59 +0800)]
Fetch: refactored out ngx_js_http_resolve_done().
Zhidao HONG [Fri, 11 Apr 2025 13:57:02 +0000 (21:57 +0800)]
Fetch: renamed njs_js_http_destructor() as ngx_js_http_destructor().
Zhidao HONG [Fri, 11 Apr 2025 13:47:52 +0000 (21:47 +0800)]
Fetch: generalize ngx_js_http_error().
Refactored to support both njs and QuickJS, which have different error
formats when throwing exceptions.
Zhidao HONG [Tue, 8 Apr 2025 15:00:42 +0000 (23:00 +0800)]
Fetch: remove unused parameter in ngx_js_http_error().
No functional changes.
Dmitry Volyntsev [Thu, 10 Apr 2025 00:19:37 +0000 (17:19 -0700)]
Fixed typo in stream event handler debug message.
Dmitry Volyntsev [Thu, 10 Apr 2025 00:18:53 +0000 (17:18 -0700)]
Version bump.
Dmitry Volyntsev [Tue, 8 Apr 2025 01:53:52 +0000 (18:53 -0700)]
Version 0.8.10.
Dmitry Volyntsev [Tue, 8 Apr 2025 01:28:50 +0000 (18:28 -0700)]
QuickJS: ignoring rejected promises while destroying context.
Dmitry Volyntsev [Thu, 3 Apr 2025 00:47:10 +0000 (17:47 -0700)]
QuickJS: added xml to nginx modules.
Missed in
cec9a1650 .