From: Christopher Faulet <cfaulet@haproxy.com>
Date: Wed, 18 Sep 2019 09:16:02 +0000 (+0200)
Subject: CLEANUP: fcgi-app: Remove useless test on fcgi_conf pointer
X-Git-Tag: v2.1-dev2~58
X-Git-Url: http://www.kaiwu.me/postgresql/commit/?a=commitdiff_plain;h=d432b3e5c875aa8b24ae993ae19c1beb7f5485b9;p=haproxy.git

CLEANUP: fcgi-app: Remove useless test on fcgi_conf pointer

fcgi_conf was already tested after allocation. No need to test it again.
This patch fixes the isssue #285.
---

diff --git a/src/fcgi-app.c b/src/fcgi-app.c
index 4db296feb..aeda8216b 100644
--- a/src/fcgi-app.c
+++ b/src/fcgi-app.c
@@ -620,8 +620,6 @@ static int proxy_parse_use_fcgi_app(char **args, int section, struct proxy *curp
 	fcgi_conf->name = strdup(args[1]);
 	LIST_INIT(&fcgi_conf->param_rules);
 	LIST_INIT(&fcgi_conf->hdr_rules);
-	if (!fcgi_conf)
-		goto err;
 
 	/* Register the filter */
 	fconf = calloc(1, sizeof(*fconf));