From: hongzhidao <hongzhidao@gmail.com>
Date: Sun, 21 Apr 2019 09:36:25 +0000 (+0800)
Subject: Restricted function declaration to top level or inside a block.
X-Git-Tag: 0.3.2~58
X-Git-Url: http://www.kaiwu.me/postgresql/commit/?a=commitdiff_plain;h=c53a53f3e5a844789f06f75ba6d338f2488af532;p=njs.git

Restricted function declaration to top level or inside a block.
---

diff --git a/njs/njs_parser.c b/njs/njs_parser.c
index e40c7478..54b6c16d 100644
--- a/njs/njs_parser.c
+++ b/njs/njs_parser.c
@@ -492,6 +492,12 @@ njs_parser_block(njs_vm_t *vm, njs_parser_t *parser, njs_token_t token)
 {
     njs_parser_node_t  *node;
 
+    if (token == NJS_TOKEN_FUNCTION) {
+        njs_parser_syntax_error(vm, parser,
+              "Functions can only be declared at top level or inside a block");
+        return NJS_TOKEN_ILLEGAL;
+    }
+
     token = njs_parser_statement(vm, parser, token);
     if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) {
         return token;
diff --git a/njs/test/njs_unit_test.c b/njs/test/njs_unit_test.c
index 5a267f61..230e2b9a 100644
--- a/njs/test/njs_unit_test.c
+++ b/njs/test/njs_unit_test.c
@@ -5725,6 +5725,27 @@ static njs_unit_test_t  njs_test[] =
     { nxt_string("\n{\nreturn;\n}"),
       nxt_string("SyntaxError: Illegal return statement in 3") },
 
+    { nxt_string("if (1) function f(){}"),
+      nxt_string("SyntaxError: Functions can only be declared at top level or inside a block in 1") },
+
+    { nxt_string("if (1) { function f(){}}"),
+      nxt_string("undefined") },
+
+    { nxt_string("while (1) function f() { }"),
+      nxt_string("SyntaxError: Functions can only be declared at top level or inside a block in 1") },
+
+    { nxt_string("while (1) { break; function f(){}}"),
+      nxt_string("undefined") },
+
+    { nxt_string("for (;;) function f() { }"),
+      nxt_string("SyntaxError: Functions can only be declared at top level or inside a block in 1") },
+
+    { nxt_string("for (;;) { break; function f(){}}"),
+      nxt_string("undefined") },
+
+    { nxt_string("do function f() { } while (0)"),
+      nxt_string("SyntaxError: Functions can only be declared at top level or inside a block in 1") },
+
     { nxt_string("function f() { return f() } f()"),
       nxt_string("RangeError: Maximum call stack size exceeded") },