From: Dmitry Volyntsev Date: Mon, 5 Aug 2019 15:17:15 +0000 (+0300) Subject: Using njs_is_defined() where appropriate. X-Git-Tag: 0.3.4~23 X-Git-Url: http://www.kaiwu.me/postgresql/commit/?a=commitdiff_plain;h=ac8f772c72d82d96635f50a045b2ee39bb2897c0;p=njs.git Using njs_is_defined() where appropriate. --- diff --git a/src/njs_array.c b/src/njs_array.c index cbdd6e00..2e083a7f 100644 --- a/src/njs_array.c +++ b/src/njs_array.c @@ -434,8 +434,8 @@ njs_array_prototype_slice(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, length = 0; } else { - if (!njs_is_undefined(njs_arg(args, nargs, 2))) { - end = njs_primitive_value_to_integer(&args[2]); + if (njs_is_defined(njs_arg(args, nargs, 2))) { + end = njs_primitive_value_to_integer(njs_argument(args, 2)); } else { end = length; diff --git a/src/njs_json.c b/src/njs_json.c index b20b7ba9..09c2d5d7 100644 --- a/src/njs_json.c +++ b/src/njs_json.c @@ -1408,7 +1408,7 @@ start: break; case NJS_JSON_ARRAY_TO_JSON_REPLACED: - if (!njs_is_undefined(&stringify->retval) + if (njs_is_defined(&stringify->retval) && njs_is_function(&stringify->replacer)) { ret = njs_json_stringify_replacer(vm, stringify, NULL, diff --git a/src/njs_object_prop.c b/src/njs_object_prop.c index fd9539fd..81d4d39c 100644 --- a/src/njs_object_prop.c +++ b/src/njs_object_prop.c @@ -348,7 +348,7 @@ njs_descriptor_prop(njs_vm_t *vm, const njs_value_t *name, pr = njs_object_property(vm, desc, &pq); if (pr != NULL) { - if (!njs_is_undefined(&pr->value) && !njs_is_function(&pr->value)) { + if (njs_is_defined(&pr->value) && !njs_is_function(&pr->value)) { njs_type_error(vm, "Getter must be a function"); return NULL; } @@ -365,7 +365,7 @@ njs_descriptor_prop(njs_vm_t *vm, const njs_value_t *name, pr = njs_object_property(vm, desc, &pq); if (pr != NULL) { - if (!njs_is_undefined(&pr->value) && !njs_is_function(&pr->value)) { + if (njs_is_defined(&pr->value) && !njs_is_function(&pr->value)) { njs_type_error(vm, "Setter must be a function"); return NULL; } diff --git a/src/njs_regexp.c b/src/njs_regexp.c index 1f49db8e..a7507291 100644 --- a/src/njs_regexp.c +++ b/src/njs_regexp.c @@ -148,7 +148,7 @@ njs_regexp_constructor(njs_vm_t *vm, njs_value_t *args, njs_uint_t nargs, pattern = &source; } - if (!njs_is_undefined(flags)) { + if (njs_is_defined(flags)) { ret = njs_primitive_value_to_string(vm, &flags_string, flags); if (njs_slow_path(ret != NJS_OK)) { return ret; diff --git a/src/njs_string.c b/src/njs_string.c index e1bd5013..2da29d08 100644 --- a/src/njs_string.c +++ b/src/njs_string.c @@ -1290,8 +1290,8 @@ njs_string_slice_args(njs_slice_prop_t *slice, njs_value_t *args, length = 0; } else { - if (!njs_is_undefined(njs_arg(args, nargs, 2))) { - value = njs_arg(args, nargs, 2); + if (njs_is_defined(njs_arg(args, nargs, 2))) { + value = njs_argument(args, 2); end = njs_number(value); } else {