From: Valentin Bartenev Date: Sat, 4 May 2019 02:52:15 +0000 (+0300) Subject: Simplified condition in njs_function_alloc(). X-Git-Tag: 0.3.2~30 X-Git-Url: http://www.kaiwu.me/postgresql/commit/?a=commitdiff_plain;h=9155d2f51ca4987c96f304bfae50edf746c812cd;p=njs.git Simplified condition in njs_function_alloc(). There's no reason to check both flags when one depends on another. See just a few lines above: function->ctor = !lambda->arrow. Now the condition is made similar to the one in njs_method_private_copy(). --- diff --git a/njs/njs_function.c b/njs/njs_function.c index f1743cd2..9d669bcc 100644 --- a/njs/njs_function.c +++ b/njs/njs_function.c @@ -42,11 +42,11 @@ njs_function_alloc(njs_vm_t *vm, njs_function_lambda_t *lambda, function->args_offset = 1; function->u.lambda = lambda; - if (lambda->arrow || !function->ctor) { - function->object.shared_hash = vm->shared->arrow_instance_hash; + if (function->ctor) { + function->object.shared_hash = vm->shared->function_instance_hash; } else { - function->object.shared_hash = vm->shared->function_instance_hash; + function->object.shared_hash = vm->shared->arrow_instance_hash; } function->object.__proto__ = &vm->prototypes[NJS_PROTOTYPE_FUNCTION].object;