From: Roman Arutyunyan Date: Thu, 14 Sep 2023 10:15:20 +0000 (+0400) Subject: QUIC: simplified setting close timer when closing connection. X-Git-Url: http://www.kaiwu.me/postgresql/commit/?a=commitdiff_plain;h=196289ac18b94c6bb0fa4f5e9a33f12757444399;p=nginx.git QUIC: simplified setting close timer when closing connection. Previously, the timer was never reset due to an explicit check. The check was added in 36b59521a41c as part of connection close simplification. The reason was to retain the earliest timeout. However, the timeouts are all the same while QUIC handshake is in progress and resetting the timer for the same value has no performance implications. After handshake completion there's only application level. The change removes the check. --- diff --git a/src/event/quic/ngx_event_quic.c b/src/event/quic/ngx_event_quic.c index b23434c0e..df3833e91 100644 --- a/src/event/quic/ngx_event_quic.c +++ b/src/event/quic/ngx_event_quic.c @@ -537,7 +537,7 @@ ngx_quic_close_connection(ngx_connection_t *c, ngx_int_t rc) qc->error_level = ctx->level; (void) ngx_quic_send_cc(c); - if (rc == NGX_OK && !qc->close.timer_set) { + if (rc == NGX_OK) { ngx_add_timer(&qc->close, 3 * ngx_quic_pto(c, ctx)); } }