]> git.kaiwu.me - nginx.git/commitdiff
Improved check for duplicate path names in ngx_add_path().
authorValentin Bartenev <vbart@nginx.com>
Mon, 16 Sep 2013 14:49:23 +0000 (18:49 +0400)
committerValentin Bartenev <vbart@nginx.com>
Mon, 16 Sep 2013 14:49:23 +0000 (18:49 +0400)
The same path names with different "data" context should not be allowed.

In particular it rejects configurations like this:

    proxy_cache_path /var/cache/ keys_zone=one:10m max_size=1g inactive=5m;
    proxy_cache_path /var/cache/ keys_zone=two:20m max_size=4m inactive=30s;

src/core/ngx_file.c

index 176bbb6c68ac7c1b0c76045c31b872cb7bbde59d..7e6e921a39b577b62a88c08e0e0d6d468a13217f 100644 (file)
@@ -501,6 +501,14 @@ ngx_add_path(ngx_conf_t *cf, ngx_path_t **slot)
         if (p[i]->name.len == path->name.len
             && ngx_strcmp(p[i]->name.data, path->name.data) == 0)
         {
+            if (p[i]->data != path->data) {
+                ngx_conf_log_error(NGX_LOG_EMERG, cf, 0,
+                                   "the same path name \"%V\" "
+                                   "used in %s:%ui and",
+                                   &p[i]->name, p[i]->conf_file, p[i]->line);
+                return NGX_ERROR;
+            }
+
             for (n = 0; n < 3; n++) {
                 if (p[i]->level[n] != path->level[n]) {
                     if (path->conf_file == NULL) {