]> git.kaiwu.me - nginx.git/commitdiff
SSL: logging level of "peer closed connection in SSL handshake".
authorMaxim Dounin <mdounin@mdounin.ru>
Fri, 4 Jul 2014 18:14:36 +0000 (22:14 +0400)
committerMaxim Dounin <mdounin@mdounin.ru>
Fri, 4 Jul 2014 18:14:36 +0000 (22:14 +0400)
Previously, the NGX_LOG_INFO level was used unconditionally.  This is
correct for client SSL connections, but too low for connections to
upstream servers.  To resolve this, ngx_connection_error() now used
to log this error, it will select logging level appropriately.

With this change, if an upstream connection is closed during SSL
handshake, it is now properly logged at "error" level.

src/event/ngx_event_openssl.c

index ed240ef3bb9e38441c6379a56cd8ed1c80dd6437..50691ade7045002371963fa025046424eb1f4fcd 100644 (file)
@@ -1112,8 +1112,8 @@ ngx_ssl_handshake(ngx_connection_t *c)
     c->read->eof = 1;
 
     if (sslerr == SSL_ERROR_ZERO_RETURN || ERR_peek_error() == 0) {
-        ngx_log_error(NGX_LOG_INFO, c->log, err,
-                      "peer closed connection in SSL handshake");
+        ngx_connection_error(c, err,
+                             "peer closed connection in SSL handshake");
 
         return NGX_ERROR;
     }