]> git.kaiwu.me - njs.git/commitdiff
Exact values for default switch case expressions.
authorIgor Sysoev <igor@sysoev.ru>
Tue, 3 Apr 2018 14:55:56 +0000 (17:55 +0300)
committerIgor Sysoev <igor@sysoev.ru>
Tue, 3 Apr 2018 14:55:56 +0000 (17:55 +0300)
njs/njs_lexer.c
njs/njs_string.c
njs/njs_string.h
njs/njs_vm.c

index 1b327ff8129dbe09096ea2d222750bfc24e47d1f..3afe573cfd3b8a5ef72aedca42ab9a803a29b451 100644 (file)
@@ -427,7 +427,8 @@ njs_lexer_next_token(njs_lexer_t *lexer)
             lexer->text.length = lexer->start - lexer->text.start;
             return token;
 
-        default:  /* NJS_TOKEN_ILLEGAL */
+        case NJS_TOKEN_ILLEGAL:
+        default:
             lexer->start--;
             return token;
         }
index 03465159ad4abff31f0907f71d04050861b2bf35..504f47e500501646310de64b3f6f230f4120e021 100644 (file)
@@ -2137,7 +2137,8 @@ njs_string_prototype_search(njs_vm_t *vm, njs_value_t *args, nxt_uint_t nargs,
 
             goto done;
 
-        default:  /* NJS_VOID */
+        case NJS_VOID:
+        default:
             goto done;
         }
 
@@ -2452,7 +2453,8 @@ njs_string_prototype_split(njs_vm_t *vm, njs_value_t *args, nxt_uint_t nargs,
 
             goto done;
 
-        default: /* NJS_VOID */
+        case NJS_VOID:
+        default:
             break;
         }
     }
index 6e9c82c0324bcba20248c5e77415185a3901488f..caf8dd39f551e815105c105e06b38db7a16d72e2 100644 (file)
@@ -112,7 +112,8 @@ njs_string_length(njs_utf8_t utf8, u_char *start, size_t size)
     case NJS_STRING_ASCII:
         return size;
 
-    default:  /* NJS_STRING_UTF8 */
+    case NJS_STRING_UTF8:
+    default:
         length = nxt_utf8_length(start, size);
 
         return (length >= 0) ? length : 0;
index 87b0cdcff2fbf78442fcdf169d2d0aebc49bd19c..4d500acc729537774c78e16237bf2ce9a8d48dda 100644 (file)
@@ -649,9 +649,9 @@ njs_vmcode_property_get(njs_vm_t *vm, njs_value_t *object,
 
         return sizeof(njs_vmcode_prop_get_t);
 
+    case NJS_TRAP_PROPERTY:
+    case NXT_ERROR:
     default:
-        /* NJS_TRAP_PROPERTY */
-        /* NXT_ERROR */
 
         return ret;
     }
@@ -760,9 +760,9 @@ njs_vmcode_property_set(njs_vm_t *vm, njs_value_t *object,
 
         return sizeof(njs_vmcode_prop_set_t);
 
+    case NJS_TRAP_PROPERTY:
+    case NXT_ERROR:
     default:
-        /* NJS_TRAP_PROPERTY */
-        /* NXT_ERROR */
 
         return ret;
     }
@@ -844,9 +844,9 @@ njs_vmcode_property_in(njs_vm_t *vm, njs_value_t *object, njs_value_t *property)
 
         break;
 
+    case NJS_TRAP_PROPERTY:
+    case NXT_ERROR:
     default:
-        /* NJS_TRAP_PROPERTY */
-        /* NXT_ERROR */
 
         return ret;
     }
@@ -946,9 +946,9 @@ njs_vmcode_property_delete(njs_vm_t *vm, njs_value_t *object,
 
         break;
 
+    case NJS_TRAP_PROPERTY:
+    case NXT_ERROR:
     default:
-        /* NJS_TRAP_PROPERTY */
-        /* NXT_ERROR */
 
         return ret;
     }
@@ -1059,7 +1059,9 @@ njs_property_query(njs_vm_t *vm, njs_property_query_t *pq, njs_value_t *object,
         obj = NULL;
         break;
 
-    default:  /* NJS_VOID, NJS_NULL. */
+    case NJS_VOID:
+    case NJS_NULL:
+    default:
         if (nxt_fast_path(njs_is_primitive(property))) {
 
             ret = njs_primitive_value_to_string(vm, &pq->value, property);