]> git.kaiwu.me - nginx.git/commitdiff
Fixed checking ngx_tcp_push() and ngx_tcp_nopush() return values.
authorRuslan Ermilov <ru@nginx.com>
Mon, 19 Mar 2018 13:28:23 +0000 (16:28 +0300)
committerRuslan Ermilov <ru@nginx.com>
Mon, 19 Mar 2018 13:28:23 +0000 (16:28 +0300)
No functional changes.

src/http/ngx_http_upstream.c
src/os/unix/ngx_freebsd_sendfile_chain.c
src/os/unix/ngx_linux_sendfile_chain.c

index 680b664be776cd1663bbd14f38dac52059e82762..e6f9c09dc17fb3ba2f7dc8e1030ea0cdb0676cd0 100644 (file)
@@ -2020,7 +2020,7 @@ ngx_http_upstream_send_request(ngx_http_request_t *r, ngx_http_upstream_t *u,
     }
 
     if (c->tcp_nopush == NGX_TCP_NOPUSH_SET) {
-        if (ngx_tcp_push(c->fd) == NGX_ERROR) {
+        if (ngx_tcp_push(c->fd) == -1) {
             ngx_log_error(NGX_LOG_CRIT, c->log, ngx_socket_errno,
                           ngx_tcp_push_n " failed");
             ngx_http_upstream_finalize_request(r, u,
index 4822e72bb82802a6a6979c3b5994f3d59c6f83f8..3d415bd2cf27ad831e01378e1bbfd7f8a13e6cde 100644 (file)
@@ -135,7 +135,7 @@ ngx_freebsd_sendfile_chain(ngx_connection_t *c, ngx_chain_t *in, off_t limit)
             if (ngx_freebsd_use_tcp_nopush
                 && c->tcp_nopush == NGX_TCP_NOPUSH_UNSET)
             {
-                if (ngx_tcp_nopush(c->fd) == NGX_ERROR) {
+                if (ngx_tcp_nopush(c->fd) == -1) {
                     err = ngx_socket_errno;
 
                     /*
index b44724cdd61880fc819d2215a3b03863f9009793..5695839b0a26cae65920bff38a2a53bc568a78bd 100644 (file)
@@ -130,7 +130,7 @@ ngx_linux_sendfile_chain(ngx_connection_t *c, ngx_chain_t *in, off_t limit)
 
             if (c->tcp_nodelay == NGX_TCP_NODELAY_UNSET) {
 
-                if (ngx_tcp_nopush(c->fd) == NGX_ERROR) {
+                if (ngx_tcp_nopush(c->fd) == -1) {
                     err = ngx_socket_errno;
 
                     /*