]> git.kaiwu.me - njs.git/commitdiff
Removed dead code in njs_value_property_set() after df385232d2af.
authorDmitry Volyntsev <xeioex@nginx.com>
Wed, 7 Aug 2019 12:17:57 +0000 (15:17 +0300)
committerDmitry Volyntsev <xeioex@nginx.com>
Wed, 7 Aug 2019 12:17:57 +0000 (15:17 +0300)
Found by Coverity Scan (CID 1452240).

src/njs_value.c

index f2718e4e5602b411e5e1fcc00f06b46f6656875d..e9abc9cc8fa68ed6ebc66319750c5bfaa668da3f 100644 (file)
@@ -1056,7 +1056,7 @@ njs_value_property_set(njs_vm_t *vm, njs_value_t *value, njs_value_t *key,
     njs_value_t *setval)
 {
     njs_int_t             ret;
-    njs_object_prop_t     *prop, *shared;
+    njs_object_prop_t     *prop;
     njs_property_query_t  pq;
 
     if (njs_is_primitive(value)) {
@@ -1065,8 +1065,6 @@ njs_value_property_set(njs_vm_t *vm, njs_value_t *value, njs_value_t *key,
         return NJS_ERROR;
     }
 
-    shared = NULL;
-
     njs_property_query_init(&pq, NJS_PROPERTY_QUERY_SET, 0);
 
     ret = njs_property_query(vm, &pq, value, key);
@@ -1158,11 +1156,6 @@ njs_value_property_set(njs_vm_t *vm, njs_value_t *value, njs_value_t *key,
         return NJS_ERROR;
     }
 
-    if (njs_slow_path(shared != NULL)) {
-        prop->enumerable = shared->enumerable;
-        prop->configurable = shared->configurable;
-    }
-
     pq.lhq.replace = 0;
     pq.lhq.value = prop;
     pq.lhq.pool = vm->mem_pool;