]> git.kaiwu.me - njs.git/commitdiff
Avoiding modification of vm->retval in njs_promise_alloc().
authorDmitry Volyntsev <xeioex@nginx.com>
Wed, 16 Dec 2020 20:27:31 +0000 (20:27 +0000)
committerDmitry Volyntsev <xeioex@nginx.com>
Wed, 16 Dec 2020 20:27:31 +0000 (20:27 +0000)
Alloc functions are not expected to modify existing values.

src/njs_promise.c

index c676f6819b5cff7b0596190ac192e81db4dc8867..a31f2cc5b30b6f94c3101e3a68555cb3766fcb12 100644 (file)
@@ -107,7 +107,6 @@ njs_promise_alloc(njs_vm_t *vm)
     njs_queue_init(&data->fulfill_queue);
     njs_queue_init(&data->reject_queue);
 
-    njs_set_promise(&vm->retval, promise);
     njs_set_data(&promise->value, data, 0);
 
     return promise;