]> git.kaiwu.me - nginx.git/commitdiff
Core: fixed wrong indices in listening sockets compare loops.
authorMaxim Dounin <mdounin@mdounin.ru>
Fri, 7 Mar 2014 11:17:38 +0000 (15:17 +0400)
committerMaxim Dounin <mdounin@mdounin.ru>
Fri, 7 Mar 2014 11:17:38 +0000 (15:17 +0400)
Proper use is "ls[i]" and "nls[n]".  Previous code used it wrong in
several places, likely due to cut-n-paste errors.

src/core/ngx_cycle.c

index 86ed9a6da9ac47fd70cec7c2e6b443f0498d17e1..d1a89ae1a45612f177b0b22c1cae458e1c1616aa 100644 (file)
@@ -494,14 +494,14 @@ ngx_init_cycle(ngx_cycle_t *old_cycle)
                 }
 
                 if (ngx_cmp_sockaddr(nls[n].sockaddr, nls[n].socklen,
-                                     ls[i].sockaddr, ls[n].socklen, 1)
+                                     ls[i].sockaddr, ls[i].socklen, 1)
                     == NGX_OK)
                 {
                     nls[n].fd = ls[i].fd;
                     nls[n].previous = &ls[i];
                     ls[i].remain = 1;
 
-                    if (ls[n].backlog != nls[i].backlog) {
+                    if (ls[i].backlog != nls[n].backlog) {
                         nls[n].listen = 1;
                     }
 
@@ -532,7 +532,7 @@ ngx_init_cycle(ngx_cycle_t *old_cycle)
 
 #if (NGX_HAVE_DEFERRED_ACCEPT && defined TCP_DEFER_ACCEPT)
 
-                    if (ls[n].deferred_accept && !nls[n].deferred_accept) {
+                    if (ls[i].deferred_accept && !nls[n].deferred_accept) {
                         nls[n].delete_deferred = 1;
 
                     } else if (ls[i].deferred_accept != nls[n].deferred_accept)