]> git.kaiwu.me - njs.git/commitdiff
Removed surplus for loop.
authorDmitry Volyntsev <xeioex@nginx.com>
Mon, 24 Dec 2018 10:59:27 +0000 (13:59 +0300)
committerDmitry Volyntsev <xeioex@nginx.com>
Mon, 24 Dec 2018 10:59:27 +0000 (13:59 +0300)
Left over after simplifications in 4e62b7a295e0.

Found by Coverity (CID 1441823).

njs/njs_parser_expression.c

index 3669fb2fc23fc4426ec6fd0f39bc2ec5f0a07d15..f615ff469e51f057ca323c8c2f1b588892c7e8d5 100644 (file)
@@ -536,37 +536,35 @@ njs_parser_exponential_expression(njs_vm_t *vm, njs_parser_t *parser,
         return token;
     }
 
-    for ( ;; ) {
-        if (token == NJS_TOKEN_EXPONENTIATION) {
-
-            node = njs_parser_node_alloc(vm);
-            if (nxt_slow_path(node == NULL)) {
-                return NJS_TOKEN_ERROR;
-            }
+    if (token == NJS_TOKEN_EXPONENTIATION) {
 
-            node->token = token;
-            node->u.operation = njs_vmcode_exponentiation;
-            node->scope = parser->scope;
-            node->left = parser->node;
-            node->left->dest = node;
+        node = njs_parser_node_alloc(vm);
+        if (nxt_slow_path(node == NULL)) {
+            return NJS_TOKEN_ERROR;
+        }
 
-            token = njs_parser_token(parser);
-            if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) {
-                return token;
-            }
+        node->token = token;
+        node->u.operation = njs_vmcode_exponentiation;
+        node->scope = parser->scope;
+        node->left = parser->node;
+        node->left->dest = node;
 
-            token = njs_parser_exponential_expression(vm, parser, NULL, token);
-            if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) {
-                return token;
-            }
+        token = njs_parser_token(parser);
+        if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) {
+            return token;
+        }
 
-            node->right = parser->node;
-            node->right->dest = node;
-            parser->node = node;
+        token = njs_parser_exponential_expression(vm, parser, NULL, token);
+        if (nxt_slow_path(token <= NJS_TOKEN_ILLEGAL)) {
+            return token;
         }
 
-        return token;
+        node->right = parser->node;
+        node->right->dest = node;
+        parser->node = node;
     }
+
+    return token;
 }