]> git.kaiwu.me - njs.git/commitdiff
Fixed static analyzer issues.
authorVadim Zhestikov <v.zhestikov@f5.com>
Wed, 26 Oct 2022 23:33:15 +0000 (16:33 -0700)
committerVadim Zhestikov <v.zhestikov@f5.com>
Wed, 26 Oct 2022 23:33:15 +0000 (16:33 -0700)
src/njs_builtin.c
src/njs_object.c
src/njs_object_prop.c
src/njs_value.c
src/njs_vmcode.c

index 6c0c7786573faadb74e2f3630fb10e689a818a19..bcffed9a5c71bf04460e25d1587620cac78fb2c5 100644 (file)
@@ -390,6 +390,11 @@ njs_builtin_traverse(njs_vm_t *vm, njs_traverse_t *traverse, void *data)
         }
     }
 
+    if (traverse == NULL) {
+        njs_type_error(vm, "njs_builtin_traverse() traverse arg is NULL");
+        return NJS_ERROR;
+    }
+
     n = 0;
 
     while (traverse != NULL) {
index cc3bc02d78a1cb49210f279c0fecc08a92757a84..0ccbeff01cf63aae0ec5af3842bfbba4d4b078db 100644 (file)
@@ -2372,7 +2372,7 @@ njs_object_prototype_has_own_property(njs_vm_t *vm, njs_value_t *args,
 
     case NJS_ERROR:
     default:
-        return ret;
+        return NJS_ERROR;
     }
 }
 
@@ -2420,7 +2420,7 @@ njs_object_prototype_prop_is_enumerable(njs_vm_t *vm, njs_value_t *args,
 
     case NJS_ERROR:
     default:
-        return ret;
+        return NJS_ERROR;
     }
 
     vm->retval = *retval;
index d6e0c27f588d44f9e0089ec2a27a081ac38a4dd7..2acc2f4212ad2066422d7a072cdb19f935fb2f10 100644 (file)
@@ -842,7 +842,7 @@ njs_object_prop_descriptor(njs_vm_t *vm, njs_value_t *dest,
 
     case NJS_ERROR:
     default:
-        return ret;
+        return NJS_ERROR;
     }
 
     desc = njs_object_alloc(vm);
index 48cf9ed331a4cd5baa39c4eace745555e9baf073..d6f1eb2aa6404033c749f090de7873615b2d2ee5 100644 (file)
@@ -1108,7 +1108,7 @@ slow_path:
     case NJS_ERROR:
     default:
 
-        return ret;
+        return NJS_ERROR;
     }
 
     return NJS_OK;
@@ -1282,7 +1282,7 @@ slow_path:
     case NJS_ERROR:
     default:
 
-        return ret;
+        return NJS_ERROR;
     }
 
     if (njs_slow_path(!njs_object(value)->extensible)) {
index 4fd13249c02ad238f04c139b4a7857ba8dece1f1..6afd04137322dd135ce8edaf8d1e634b078f8e1b 100644 (file)
@@ -103,7 +103,6 @@ njs_vmcode_interpreter(njs_vm_t *vm, u_char *pc, void *promise_cap,
     njs_native_frame_t           *previous, *native;
     njs_property_next_t          *next;
     njs_vmcode_import_t          *import;
-    njs_vmcode_finally_t         *finally;
     njs_vmcode_generic_t         *vmcode;
     njs_vmcode_variable_t        *var;
     njs_vmcode_prop_get_t        *get;
@@ -1722,9 +1721,6 @@ NEXT_LBL;
 
         value2 = (njs_value_t *) vmcode->operand1;
 
-        finally = (njs_vmcode_finally_t *) pc;
-        value1 = njs_scope_value(vm, finally->exit_value);
-
         ret = njs_vmcode_finally(vm, NULL, value2, pc);
 
         switch (ret) {