]> git.kaiwu.me - nginx.git/commitdiff
OCSP stapling: fix error logging of successful OCSP responses.
authorPiotr Sikora <piotr@cloudflare.com>
Thu, 16 May 2013 22:37:13 +0000 (15:37 -0700)
committerPiotr Sikora <piotr@cloudflare.com>
Thu, 16 May 2013 22:37:13 +0000 (15:37 -0700)
Due to a bad argument list, nginx worker would crash (SIGSEGV) while
trying to log the fact that it received OCSP response with "revoked"
or "unknown" certificate status.

While there, fix similar (but non-crashing) error a few lines above.

Signed-off-by: Piotr Sikora <piotr@cloudflare.com>
src/event/ngx_event_openssl_stapling.c

index aaa8d8ac44c0956e7322a64ee32960548779744c..77baeb98f1f8d114e58e8edeafeac8a0ad3dd376 100644 (file)
@@ -611,15 +611,14 @@ ngx_ssl_stapling_ocsp_handler(ngx_ssl_ocsp_ctx_t *ctx)
         != 1)
     {
         ngx_log_error(NGX_LOG_ERR, ctx->log, 0,
-                      "certificate status not found in the OCSP response",
-                      n, OCSP_response_status_str(n));
+                      "certificate status not found in the OCSP response");
         goto error;
     }
 
     if (n != V_OCSP_CERTSTATUS_GOOD) {
         ngx_log_error(NGX_LOG_ERR, ctx->log, 0,
                       "certificate status \"%s\" in the OCSP response",
-                      n, OCSP_cert_status_str(n));
+                      OCSP_cert_status_str(n));
         goto error;
     }