]> git.kaiwu.me - nginx.git/commit
Gzip: fixed style in $gzip_ratio variable handler.
authorRuslan Ermilov <ru@nginx.com>
Wed, 14 Jun 2017 09:49:20 +0000 (12:49 +0300)
committerRuslan Ermilov <ru@nginx.com>
Wed, 14 Jun 2017 09:49:20 +0000 (12:49 +0300)
commitfa0992ed295ba83f711ca3d1ba8fc1baaa5760ca
tree27f6d2a3fb5e068ba1f3ef2de9a15d89c735c27d
parent731d1fee8a64538882f4a7c0d2cce1137410cb15
Gzip: fixed style in $gzip_ratio variable handler.

The current style in variable handlers returning NGX_OK is to either set
v->not_found to 1, or to initialize the entire ngx_http_variable_value_t
structure.

In theory, always setting v->valid = 1 for NGX_OK would be useful, which
would mean that the value was computed and is thus valid, including the
special case of v->not_found = 1.  But currently that's not the case and
causes the (v->valid || v->not_found) check to access an uninitialized
v->valid value, which is safe only because its value doesn't matter when
v->not_found is set.
src/http/modules/ngx_http_gzip_filter_module.c