]> git.kaiwu.me - nginx.git/commit
Resolver: fixed possible use-after-free while resolving SRV.
authorRoman Arutyunyan <arut@nginx.com>
Tue, 4 Jul 2017 15:07:29 +0000 (18:07 +0300)
committerRoman Arutyunyan <arut@nginx.com>
Tue, 4 Jul 2017 15:07:29 +0000 (18:07 +0300)
commit7570718594d846787ca31914e0f8431d7a4cfad1
tree3e29a0d3f4f492bd41f11b4f4fea79a5de17f08e
parent32e3d0e693b6520d0e087160519d173bb102f906
Resolver: fixed possible use-after-free while resolving SRV.

Resolving an SRV record includes resolving its host names in subrequests.
Previously, if memory allocation failed while reporting a subrequest result
after receiving a response from a DNS server, the SRV resolve handler was
called immediately with the NGX_ERROR state.  However, if the SRV record
included another copy of the resolved name, it was reported once again.
This could trigger the use-after-free memory access after SRV resolve
handler freed the resolve context by calling ngx_resolve_name_done().

Now the SRV resolve handler is called only when all its subrequests are
completed.
src/core/ngx_resolver.c