]> git.kaiwu.me - nginx.git/commit
QUIC: fixed stream cleanup (ticket #2586).
authorRoman Arutyunyan <arut@nginx.com>
Wed, 14 Feb 2024 11:55:37 +0000 (15:55 +0400)
committerRoman Arutyunyan <arut@nginx.com>
Wed, 14 Feb 2024 11:55:37 +0000 (15:55 +0400)
commit5818f8a6693b3c0d95021f2ee58b69dcf848911c
treedfff54f77f94ae3f04976d9646b8fba8941210ff
parent5902baf680609f884a1e11ff2b82a0bffb3724cc
QUIC: fixed stream cleanup (ticket #2586).

Stream connection cleanup handler ngx_quic_stream_cleanup_handler() calls
ngx_quic_shutdown_stream() after which it resets the pointer from quic stream
to the connection (sc->connection = NULL).  Previously if this call failed,
sc->connection retained the old value, while the connection was freed by the
application code.  This resulted later in a second attempt to close the freed
connection, which lead to allocator double free error.

The fix is to reset the sc->connection pointer in case of error.
src/event/quic/ngx_event_quic_streams.c