]> git.kaiwu.me - nginx.git/commit
OCSP stapling: fixed segfault with dynamic certificate loading.
authorMaxim Dounin <mdounin@mdounin.ru>
Mon, 15 Apr 2019 16:13:09 +0000 (19:13 +0300)
committerMaxim Dounin <mdounin@mdounin.ru>
Mon, 15 Apr 2019 16:13:09 +0000 (19:13 +0300)
commit5784889fb907485978919b91c2c7f6bf0c4843e3
tree3cf7fcf23556b14a7c351ed9bc62d70e9742ec0c
parentaaa1a5706033bd0e33de7beb237e52e2a19a3245
OCSP stapling: fixed segfault with dynamic certificate loading.

If OCSP stapling was enabled with dynamic certificate loading, with some
OpenSSL versions (1.0.2o and older, 1.1.0h and older; fixed in 1.0.2p,
1.1.0i, 1.1.1) a segmentation fault might happen.

The reason is that during an abbreviated handshake the certificate
callback is not called, but the certificate status callback was called
(https://github.com/openssl/openssl/issues/1662), leading to NULL being
returned from SSL_get_certificate().

Fix is to explicitly check SSL_get_certificate() result.
src/event/ngx_event_openssl_stapling.c