]> git.kaiwu.me - haproxy.git/commit
BUG/MINOR: acme: contact mail should be optional, don't pass ToS bool
authorMia Kanashi <chad@redpilled.dev>
Fri, 1 May 2026 18:06:17 +0000 (21:06 +0300)
committerWilliam Lallemand <wlallemand@haproxy.com>
Tue, 5 May 2026 16:04:19 +0000 (18:04 +0200)
commit3fa0aa3664deee9b83f42b662436d7eb46ad8f3f
tree917fa1382eef9403448c7d6c9649a5c25adf8157
parentb52a0e67825248b4d7023ad2f2a82a4d7c9bd2ce
BUG/MINOR: acme: contact mail should be optional, don't pass ToS bool

According to ACME RFC contact email is optional.
Letsencrypt used it some long time ago, but not today.
Currently HAProxy always sets the value of the contact mail to a string
that is read from the config, but if that string is not specified,
it sets %s in mailto:%s to null, which cases new account request
to fail in pebble.

Also HAProxy currently passes termsOfServiceAgreed bool to requests
that contain onlyReturnExisting, that isn't needed according to the RFC
and other ACME impls.

This patch dynamically builds the account request JSON to address that.

Can be backported to 3.2
src/acme.c