]> git.kaiwu.me - nginx.git/commit
HTTP/2: fixed socket leak with an incomplete HEADERS frame.
authorSergey Kandaurov <pluknet@nginx.com>
Wed, 5 Feb 2020 13:29:23 +0000 (16:29 +0300)
committerSergey Kandaurov <pluknet@nginx.com>
Wed, 5 Feb 2020 13:29:23 +0000 (16:29 +0300)
commit16168dcb01ed5dbf6365be0d9ea0da68bf479194
tree0459f140cacdd77d4892eec56b71997a1eca2ad4
parentb7ea950a12de0619c8030e4887f6901b3364d208
HTTP/2: fixed socket leak with an incomplete HEADERS frame.

A connection could get stuck without timers if a client has partially sent
the HEADERS frame such that it was split on the individual header boundary.
In this case, it cannot be processed without the rest of the HEADERS frame.

The fix is to call ngx_http_v2_state_headers_save() in this case.  Normally,
it would be called from the ngx_http_v2_state_header_block() handler on the
next iteration, when there is not enough data to continue processing.  This
isn't the case if recv_buffer became empty and there's no more data to read.
src/http/v2/ngx_http_v2.c